mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: replace (webContents as any).destroy() with webContents.destroy() (#36653)

Browse source 
Co-authored-by: Milan Burda <miburda@microsoft.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
This commit is contained in:
Milan Burda 2022-12-14 22:07:38 +01:00 • committed by GitHub
parent fb461effae
commit 5fd7a43970
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 21 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

10
spec/api-browser-window-spec.ts
View file

@ -2206,7 +2206,7 @@ describe('BrowserWindow module', () => {
w.setBrowserView(bv);
defer(() => {
w.removeBrowserView(bv);
(bv.webContents as any).destroy();
bv.webContents.destroy();
});
await bv.webContents.loadURL('about:blank');
expect(BrowserWindow.fromWebContents(bv.webContents)!.id).to.equal(w.id);
@ -2254,7 +2254,7 @@ describe('BrowserWindow module', () => {
w.setBrowserView(bv);
defer(() => {
w.removeBrowserView(bv);
(bv.webContents as any).destroy();
bv.webContents.destroy();
});
expect(BrowserWindow.fromBrowserView(bv)!.id).to.equal(w.id);
});
@ -2268,8 +2268,8 @@ describe('BrowserWindow module', () => {
defer(() => {
w.removeBrowserView(bv1);
w.removeBrowserView(bv2);
(bv1.webContents as any).destroy();
(bv2.webContents as any).destroy();
bv1.webContents.destroy();
bv2.webContents.destroy();
});
expect(BrowserWindow.fromBrowserView(bv1)!.id).to.equal(w.id);
expect(BrowserWindow.fromBrowserView(bv2)!.id).to.equal(w.id);
@ -2278,7 +2278,7 @@ describe('BrowserWindow module', () => {
it('returns undefined if not attached', () => {
const bv = new BrowserView();
defer(() => {
(bv.webContents as any).destroy();
bv.webContents.destroy();
});
expect(BrowserWindow.fromBrowserView(bv)).to.be.null('BrowserWindow associated with bv');
});