mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: make shell.ShowItemInFolder asynchronous (#17121)

Browse source 
* fix: add scoped_blocking_calls to platform_win

1191582

* feat: make ShowItemInFolder async

* address feedback from review

* fix build
This commit is contained in:
Shelley Vohr 2019-02-27 12:58:23 +00:00 • committed by GitHub
parent 08066581b0
commit 5ecda17c7a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 40 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

4
atom/common/platform_util_mac.mm
View file

@ -59,7 +59,7 @@ NSString* GetLoginHelperBundleIdentifier() {
namespace platform_util {
bool ShowItemInFolder(const base::FilePath& path) {
void ShowItemInFolder(const base::FilePath& path) {
// The API only takes absolute path.
base::FilePath full_path =
path.IsAbsolute() ? path : base::MakeAbsoluteFilePath(path);
@ -69,9 +69,7 @@ bool ShowItemInFolder(const base::FilePath& path) {
if (!path_string || ![[NSWorkspace sharedWorkspace] selectFile:path_string
inFileViewerRootedAtPath:@""]) {
LOG(WARNING) << "NSWorkspace failed to select file " << full_path.value();
return false;
}
return true;
}
bool OpenItem(const base::FilePath& full_path) {