mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: make shell.ShowItemInFolder asynchronous (#17121)

Browse source 
* fix: add scoped_blocking_calls to platform_win

1191582

* feat: make ShowItemInFolder async

* address feedback from review

* fix build
This commit is contained in:
Shelley Vohr 2019-02-27 12:58:23 +00:00 • committed by GitHub
parent 08066581b0
commit 5ecda17c7a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 40 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

6
atom/common/platform_util_linux.cc
View file

@ -69,12 +69,12 @@ namespace platform_util {
// TODO(estade): It would be nice to be able to select the file in the file
// manager, but that probably requires extending xdg-open. For now just
// show the folder.
bool ShowItemInFolder(const base::FilePath& full_path) {
void ShowItemInFolder(const base::FilePath& full_path) {
base::FilePath dir = full_path.DirName();
if (!base::DirectoryExists(dir))
return false;
return;
return XDGOpen(dir.value(), false);
XDGOpen(dir.value(), false);
}
bool OpenItem(const base::FilePath& full_path) {