mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Guard against only specifying select or highlight handler

Browse source
This commit is contained in:
Kevin Sawicki 2017-03-13 11:22:08 -07:00
parent 0dcdd60010
commit 5e70adb511
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lib/browser/api/touch-bar.js
View file

@ -235,11 +235,14 @@ TouchBar.TouchBarScrubber = class TouchBarScrubber extends TouchBarItem {
constructor (config) { constructor (config) {
super() super()
if (config == null) config = {} if (config == null) config = {}
const {items, onSelect, onHighlight} = config const {items} = config
let {onSelect, onHighlight} = config
this.type = 'scrubber' this.type = 'scrubber'
this._addLiveProperty('items', items) this._addLiveProperty('items', items)
if (typeof onSelect === 'function' || typeof onHighlight === 'function') { if (typeof onSelect === 'function' || typeof onHighlight === 'function') {
if (onSelect == null) onSelect = () => {}
if (onHighlight == null) onHighlight = () => {}
this.onInteraction = (details) => { this.onInteraction = (details) => {
if (details.type === 'select') { if (details.type === 'select') {
onSelect(details.selectedIndex) onSelect(details.selectedIndex)