mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Remove from notification center when web contents is destroyed.

Browse source
This commit is contained in:
Cheng Zhao 2014-04-23 11:20:12 +08:00
parent 54060ed53d
commit 5e0dd5c687
4 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
brightray/browser/inspectable_web_contents_view_mac.h
View file

@ -15,6 +15,7 @@ class InspectableWebContentsViewMac : public InspectableWebContentsView {
public: public:
explicit InspectableWebContentsViewMac( explicit InspectableWebContentsViewMac(
InspectableWebContentsImpl* inspectable_web_contents_impl); InspectableWebContentsImpl* inspectable_web_contents_impl);
virtual ~InspectableWebContentsViewMac();
virtual gfx::NativeView GetNativeView() const OVERRIDE; virtual gfx::NativeView GetNativeView() const OVERRIDE;
virtual void ShowDevTools() OVERRIDE; virtual void ShowDevTools() OVERRIDE;

4
brightray/browser/inspectable_web_contents_view_mac.mm
View file

@ -17,6 +17,10 @@ InspectableWebContentsViewMac::InspectableWebContentsViewMac(InspectableWebConte
view_([[BRYInspectableWebContentsView alloc] initWithInspectableWebContentsViewMac:this]) { view_([[BRYInspectableWebContentsView alloc] initWithInspectableWebContentsViewMac:this]) {
} }
InspectableWebContentsViewMac::~InspectableWebContentsViewMac() {
[view_ removeFromNotificationCenter];
}
gfx::NativeView InspectableWebContentsViewMac::GetNativeView() const { gfx::NativeView InspectableWebContentsViewMac::GetNativeView() const {
return view_.get(); return view_.get();
} }

1
brightray/browser/mac/bry_inspectable_web_contents_view.h
View file

@ -8,6 +8,7 @@
BRYInspectableWebContentsViewPrivate *_private; BRYInspectableWebContentsViewPrivate *_private;
} }
- (void)removeFromNotificationCenter;
- (IBAction)showDevTools:(id)sender; - (IBAction)showDevTools:(id)sender;
@end @end

4
brightray/browser/mac/bry_inspectable_web_contents_view.mm
View file

@ -76,6 +76,10 @@ void SetActive(content::WebContents* web_contents, bool active) {
[super dealloc]; [super dealloc];
} }
- (void)removeFromNotificationCenter {
[NSNotificationCenter.defaultCenter removeObserver:self];
}
- (IBAction)showDevTools:(id)sender { - (IBAction)showDevTools:(id)sender {
_private->inspectableWebContentsView->inspectable_web_contents()->ShowDevTools(); _private->inspectableWebContentsView->inspectable_web_contents()->ShowDevTools();
} }