mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

build: enable JS semicolons (#22783)

Browse source
This commit is contained in:
Samuel Attard 2020-03-20 13:28:31 -07:00 • committed by GitHub
parent 24e21467b9
commit 5d657dece4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
354 changed files with 21512 additions and 21510 deletions
Download patch file Download diff file Expand all files Collapse all files

148
spec-main/version-bump-spec.ts
View file

@ -1,7 +1,7 @@
import { expect } from 'chai'
import { nextVersion } from '../script/release/version-bumper'
import * as utils from '../script/release/version-utils'
import { ifdescribe } from './spec-helpers'
import { expect } from 'chai';
import { nextVersion } from '../script/release/version-bumper';
import * as utils from '../script/release/version-utils';
import { ifdescribe } from './spec-helpers';
describe('version-bumper', () => {
describe('makeVersion', () => {
@ -10,11 +10,11 @@ describe('version-bumper', () => {
major: 2,
minor: 0,
patch: 0
}
};
const version = utils.makeVersion(components, '.')
expect(version).to.equal('2.0.0')
})
const version = utils.makeVersion(components, '.');
expect(version).to.equal('2.0.0');
});
it('makes a version with a period delimeter and a partial pre', () => {
const components = {
@ -22,11 +22,11 @@ describe('version-bumper', () => {
minor: 0,
patch: 0,
pre: ['nightly', 12345678]
}
};
const version = utils.makeVersion(components, '.', utils.preType.PARTIAL)
expect(version).to.equal('2.0.0.12345678')
})
const version = utils.makeVersion(components, '.', utils.preType.PARTIAL);
expect(version).to.equal('2.0.0.12345678');
});
it('makes a version with a period delimeter and a full pre', () => {
const components = {
@ -34,103 +34,103 @@ describe('version-bumper', () => {
minor: 0,
patch: 0,
pre: ['nightly', 12345678]
}
};
const version = utils.makeVersion(components, '.', utils.preType.FULL)
expect(version).to.equal('2.0.0-nightly.12345678')
})
})
const version = utils.makeVersion(components, '.', utils.preType.FULL);
expect(version).to.equal('2.0.0-nightly.12345678');
});
});
// On macOS Circle CI we don't have a real git environment due to running
// gclient sync on a linux machine. These tests therefore don't run as expected.
ifdescribe(!(process.platform === 'linux' && process.arch === 'arm') && process.platform !== 'darwin')('nextVersion', () => {
const nightlyPattern = /[0-9.]*(-nightly.(\d{4})(\d{2})(\d{2}))$/g
const betaPattern = /[0-9.]*(-beta[0-9.]*)/g
const nightlyPattern = /[0-9.]*(-nightly.(\d{4})(\d{2})(\d{2}))$/g;
const betaPattern = /[0-9.]*(-beta[0-9.]*)/g;
it('bumps to nightly from stable', async () => {
const version = 'v2.0.0'
const next = await nextVersion('nightly', version)
const matches = next.match(nightlyPattern)
expect(matches).to.have.lengthOf(1)
})
const version = 'v2.0.0';
const next = await nextVersion('nightly', version);
const matches = next.match(nightlyPattern);
expect(matches).to.have.lengthOf(1);
});
it('bumps to nightly from beta', async () => {
const version = 'v2.0.0-beta.1'
const next = await nextVersion('nightly', version)
const matches = next.match(nightlyPattern)
expect(matches).to.have.lengthOf(1)
})
const version = 'v2.0.0-beta.1';
const next = await nextVersion('nightly', version);
const matches = next.match(nightlyPattern);
expect(matches).to.have.lengthOf(1);
});
it('bumps to nightly from nightly', async () => {
const version = 'v2.0.0-nightly.19950901'
const next = await nextVersion('nightly', version)
const matches = next.match(nightlyPattern)
expect(matches).to.have.lengthOf(1)
})
const version = 'v2.0.0-nightly.19950901';
const next = await nextVersion('nightly', version);
const matches = next.match(nightlyPattern);
expect(matches).to.have.lengthOf(1);
});
it('bumps to a nightly version above our switch from N-0-x to N-x-y branch names', async () => {
const version = 'v2.0.0-nightly.19950901'
const next = await nextVersion('nightly', version)
const version = 'v2.0.0-nightly.19950901';
const next = await nextVersion('nightly', version);
// If it starts with v8 then we didn't bump above the 8-x-y branch
expect(next.startsWith('v8')).to.equal(false)
})
expect(next.startsWith('v8')).to.equal(false);
});
it('throws error when bumping to beta from stable', () => {
const version = 'v2.0.0'
const version = 'v2.0.0';
return expect(
nextVersion('beta', version)
).to.be.rejectedWith('Cannot bump to beta from stable.')
})
).to.be.rejectedWith('Cannot bump to beta from stable.');
});
it('bumps to beta from nightly', async () => {
const version = 'v2.0.0-nightly.19950901'
const next = await nextVersion('beta', version)
const matches = next.match(betaPattern)
expect(matches).to.have.lengthOf(1)
})
const version = 'v2.0.0-nightly.19950901';
const next = await nextVersion('beta', version);
const matches = next.match(betaPattern);
expect(matches).to.have.lengthOf(1);
});
it('bumps to beta from beta', async () => {
const version = 'v2.0.0-beta.8'
const next = await nextVersion('beta', version)
expect(next).to.equal('2.0.0-beta.9')
})
const version = 'v2.0.0-beta.8';
const next = await nextVersion('beta', version);
expect(next).to.equal('2.0.0-beta.9');
});
it('bumps to stable from beta', async () => {
const version = 'v2.0.0-beta.1'
const next = await nextVersion('stable', version)
expect(next).to.equal('2.0.0')
})
const version = 'v2.0.0-beta.1';
const next = await nextVersion('stable', version);
expect(next).to.equal('2.0.0');
});
it('bumps to stable from stable', async () => {
const version = 'v2.0.0'
const next = await nextVersion('stable', version)
expect(next).to.equal('2.0.1')
})
const version = 'v2.0.0';
const next = await nextVersion('stable', version);
expect(next).to.equal('2.0.1');
});
it('bumps to minor from stable', async () => {
const version = 'v2.0.0'
const next = await nextVersion('minor', version)
expect(next).to.equal('2.1.0')
})
const version = 'v2.0.0';
const next = await nextVersion('minor', version);
expect(next).to.equal('2.1.0');
});
it('bumps to stable from nightly', async () => {
const version = 'v2.0.0-nightly.19950901'
const next = await nextVersion('stable', version)
expect(next).to.equal('2.0.0')
})
const version = 'v2.0.0-nightly.19950901';
const next = await nextVersion('stable', version);
expect(next).to.equal('2.0.0');
});
it('throws on an invalid version', () => {
const version = 'vI.AM.INVALID'
const version = 'vI.AM.INVALID';
return expect(
nextVersion('beta', version)
).to.be.rejectedWith(`Invalid current version: ${version}`)
})
).to.be.rejectedWith(`Invalid current version: ${version}`);
});
it('throws on an invalid bump type', () => {
const version = 'v2.0.0'
const version = 'v2.0.0';
return expect(
nextVersion('WRONG', version)
).to.be.rejectedWith('Invalid bump type.')
})
})
})
).to.be.rejectedWith('Invalid bump type.');
});
});
});