mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

build: enable JS semicolons (#22783)

Browse source
This commit is contained in:
Samuel Attard 2020-03-20 13:28:31 -07:00 • committed by GitHub
parent 24e21467b9
commit 5d657dece4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
354 changed files with 21512 additions and 21510 deletions
Download patch file Download diff file Expand all files Collapse all files

78
spec-main/api-web-contents-view-spec.ts
View file

@ -1,58 +1,58 @@
import { expect } from 'chai'
import * as ChildProcess from 'child_process'
import * as path from 'path'
import { emittedOnce } from './events-helpers'
import { closeWindow } from './window-helpers'
import { expect } from 'chai';
import * as ChildProcess from 'child_process';
import * as path from 'path';
import { emittedOnce } from './events-helpers';
import { closeWindow } from './window-helpers';
import { webContents, TopLevelWindow, WebContentsView } from 'electron'
import { webContents, TopLevelWindow, WebContentsView } from 'electron';
describe('WebContentsView', () => {
let w: TopLevelWindow
afterEach(() => closeWindow(w as any).then(() => { w = null as unknown as TopLevelWindow }))
let w: TopLevelWindow;
afterEach(() => closeWindow(w as any).then(() => { w = null as unknown as TopLevelWindow; }));
it('can be used as content view', () => {
const web = (webContents as any).create({})
w = new TopLevelWindow({ show: false })
w.setContentView(new WebContentsView(web))
})
const web = (webContents as any).create({});
w = new TopLevelWindow({ show: false });
w.setContentView(new WebContentsView(web));
});
it('prevents adding same WebContents', () => {
const web = (webContents as any).create({})
w = new TopLevelWindow({ show: false })
w.setContentView(new WebContentsView(web))
const web = (webContents as any).create({});
w = new TopLevelWindow({ show: false });
w.setContentView(new WebContentsView(web));
expect(() => {
w.setContentView(new WebContentsView(web))
}).to.throw('The WebContents has already been added to a View')
})
w.setContentView(new WebContentsView(web));
}).to.throw('The WebContents has already been added to a View');
});
describe('new WebContentsView()', () => {
it('does not crash on exit', async () => {
const appPath = path.join(__dirname, 'fixtures', 'api', 'leak-exit-webcontentsview.js')
const electronPath = process.execPath
const appProcess = ChildProcess.spawn(electronPath, ['--enable-logging', appPath])
let output = ''
appProcess.stdout.on('data', data => { output += data })
appProcess.stderr.on('data', data => { output += data })
const [code] = await emittedOnce(appProcess, 'exit')
const appPath = path.join(__dirname, 'fixtures', 'api', 'leak-exit-webcontentsview.js');
const electronPath = process.execPath;
const appProcess = ChildProcess.spawn(electronPath, ['--enable-logging', appPath]);
let output = '';
appProcess.stdout.on('data', data => { output += data; });
appProcess.stderr.on('data', data => { output += data; });
const [code] = await emittedOnce(appProcess, 'exit');
if (code !== 0) {
console.log(code, output)
console.log(code, output);
}
expect(code).to.equal(0)
})
})
expect(code).to.equal(0);
});
});
function triggerGCByAllocation () {
const arr = []
const arr = [];
for (let i = 0; i < 1000000; i++) {
arr.push([])
arr.push([]);
}
return arr
return arr;
}
it('doesn\'t crash when GCed during allocation', (done) => {
const web = (webContents as any).create({})
const web = (webContents as any).create({});
// eslint-disable-next-line no-new
new WebContentsView(web)
new WebContentsView(web);
setTimeout(() => {
// NB. the crash we're testing for is the lack of a current `v8::Context`
// when emitting an event in WebContents's destructor. V8 is inconsistent
@ -61,8 +61,8 @@ describe('WebContentsView', () => {
// causes a GC in which there _is_ a current context, so the crash isn't
// triggered. Thus, we force a GC by other means: namely, by allocating a
// bunch of stuff.
triggerGCByAllocation()
done()
})
})
})
triggerGCByAllocation();
done();
});
});
});