build: enable JS semicolons (#22783)
This commit is contained in:
Samuel Attard
GitHub
parent
24e21467b9
commit
5d657dece4
354 changed files with 21512 additions and 21510 deletions
|
|
@ -1,233 +1,233 @@
|
|||
import { expect } from 'chai'
|
||||
import * as http from 'http'
|
||||
import * as path from 'path'
|
||||
import { AddressInfo } from 'net'
|
||||
import { BrowserWindow } from 'electron'
|
||||
import { closeAllWindows } from './window-helpers'
|
||||
import { emittedOnce } from './events-helpers'
|
||||
import { expect } from 'chai';
|
||||
import * as http from 'http';
|
||||
import * as path from 'path';
|
||||
import { AddressInfo } from 'net';
|
||||
import { BrowserWindow } from 'electron';
|
||||
import { closeAllWindows } from './window-helpers';
|
||||
import { emittedOnce } from './events-helpers';
|
||||
|
||||
describe('debugger module', () => {
|
||||
const fixtures = path.resolve(__dirname, '..', 'spec', 'fixtures')
|
||||
let w: BrowserWindow
|
||||
const fixtures = path.resolve(__dirname, '..', 'spec', 'fixtures');
|
||||
let w: BrowserWindow;
|
||||
|
||||
beforeEach(() => {
|
||||
w = new BrowserWindow({
|
||||
show: false,
|
||||
width: 400,
|
||||
height: 400
|
||||
})
|
||||
})
|
||||
});
|
||||
});
|
||||
|
||||
afterEach(closeAllWindows)
|
||||
afterEach(closeAllWindows);
|
||||
|
||||
describe('debugger.attach', () => {
|
||||
it('succeeds when devtools is already open', done => {
|
||||
w.webContents.on('did-finish-load', () => {
|
||||
w.webContents.openDevTools()
|
||||
w.webContents.openDevTools();
|
||||
try {
|
||||
w.webContents.debugger.attach()
|
||||
w.webContents.debugger.attach();
|
||||
} catch (err) {
|
||||
done(`unexpected error : ${err}`)
|
||||
done(`unexpected error : ${err}`);
|
||||
}
|
||||
expect(w.webContents.debugger.isAttached()).to.be.true()
|
||||
done()
|
||||
})
|
||||
w.webContents.loadURL('about:blank')
|
||||
})
|
||||
expect(w.webContents.debugger.isAttached()).to.be.true();
|
||||
done();
|
||||
});
|
||||
w.webContents.loadURL('about:blank');
|
||||
});
|
||||
|
||||
it('fails when protocol version is not supported', done => {
|
||||
try {
|
||||
w.webContents.debugger.attach('2.0')
|
||||
w.webContents.debugger.attach('2.0');
|
||||
} catch (err) {
|
||||
expect(w.webContents.debugger.isAttached()).to.be.false()
|
||||
done()
|
||||
expect(w.webContents.debugger.isAttached()).to.be.false();
|
||||
done();
|
||||
}
|
||||
})
|
||||
});
|
||||
|
||||
it('attaches when no protocol version is specified', done => {
|
||||
try {
|
||||
w.webContents.debugger.attach()
|
||||
w.webContents.debugger.attach();
|
||||
} catch (err) {
|
||||
done(`unexpected error : ${err}`)
|
||||
done(`unexpected error : ${err}`);
|
||||
}
|
||||
expect(w.webContents.debugger.isAttached()).to.be.true()
|
||||
done()
|
||||
})
|
||||
})
|
||||
expect(w.webContents.debugger.isAttached()).to.be.true();
|
||||
done();
|
||||
});
|
||||
});
|
||||
|
||||
describe('debugger.detach', () => {
|
||||
it('fires detach event', (done) => {
|
||||
w.webContents.debugger.on('detach', (e, reason) => {
|
||||
expect(reason).to.equal('target closed')
|
||||
expect(w.webContents.debugger.isAttached()).to.be.false()
|
||||
done()
|
||||
})
|
||||
expect(reason).to.equal('target closed');
|
||||
expect(w.webContents.debugger.isAttached()).to.be.false();
|
||||
done();
|
||||
});
|
||||
|
||||
try {
|
||||
w.webContents.debugger.attach()
|
||||
w.webContents.debugger.attach();
|
||||
} catch (err) {
|
||||
done(`unexpected error : ${err}`)
|
||||
done(`unexpected error : ${err}`);
|
||||
}
|
||||
w.webContents.debugger.detach()
|
||||
})
|
||||
w.webContents.debugger.detach();
|
||||
});
|
||||
|
||||
it('doesn\'t disconnect an active devtools session', done => {
|
||||
w.webContents.loadURL('about:blank')
|
||||
w.webContents.loadURL('about:blank');
|
||||
try {
|
||||
w.webContents.debugger.attach()
|
||||
w.webContents.debugger.attach();
|
||||
} catch (err) {
|
||||
return done(`unexpected error : ${err}`)
|
||||
return done(`unexpected error : ${err}`);
|
||||
}
|
||||
w.webContents.openDevTools()
|
||||
w.webContents.openDevTools();
|
||||
w.webContents.once('devtools-opened', () => {
|
||||
w.webContents.debugger.detach()
|
||||
})
|
||||
w.webContents.debugger.detach();
|
||||
});
|
||||
w.webContents.debugger.on('detach', () => {
|
||||
expect(w.webContents.debugger.isAttached()).to.be.false()
|
||||
expect((w as any).devToolsWebContents.isDestroyed()).to.be.false()
|
||||
done()
|
||||
})
|
||||
})
|
||||
})
|
||||
expect(w.webContents.debugger.isAttached()).to.be.false();
|
||||
expect((w as any).devToolsWebContents.isDestroyed()).to.be.false();
|
||||
done();
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('debugger.sendCommand', () => {
|
||||
let server: http.Server
|
||||
let server: http.Server;
|
||||
|
||||
afterEach(() => {
|
||||
if (server != null) {
|
||||
server.close()
|
||||
server = null as any
|
||||
server.close();
|
||||
server = null as any;
|
||||
}
|
||||
})
|
||||
});
|
||||
|
||||
it('returns response', async () => {
|
||||
w.webContents.loadURL('about:blank')
|
||||
w.webContents.debugger.attach()
|
||||
w.webContents.loadURL('about:blank');
|
||||
w.webContents.debugger.attach();
|
||||
|
||||
const params = { expression: '4+2' }
|
||||
const res = await w.webContents.debugger.sendCommand('Runtime.evaluate', params)
|
||||
const params = { expression: '4+2' };
|
||||
const res = await w.webContents.debugger.sendCommand('Runtime.evaluate', params);
|
||||
|
||||
expect(res.wasThrown).to.be.undefined()
|
||||
expect(res.result.value).to.equal(6)
|
||||
expect(res.wasThrown).to.be.undefined();
|
||||
expect(res.result.value).to.equal(6);
|
||||
|
||||
w.webContents.debugger.detach()
|
||||
})
|
||||
w.webContents.debugger.detach();
|
||||
});
|
||||
|
||||
it('returns response when devtools is opened', async () => {
|
||||
w.webContents.loadURL('about:blank')
|
||||
w.webContents.debugger.attach()
|
||||
w.webContents.loadURL('about:blank');
|
||||
w.webContents.debugger.attach();
|
||||
|
||||
const opened = emittedOnce(w.webContents, 'devtools-opened')
|
||||
w.webContents.openDevTools()
|
||||
await opened
|
||||
const opened = emittedOnce(w.webContents, 'devtools-opened');
|
||||
w.webContents.openDevTools();
|
||||
await opened;
|
||||
|
||||
const params = { expression: '4+2' }
|
||||
const res = await w.webContents.debugger.sendCommand('Runtime.evaluate', params)
|
||||
const params = { expression: '4+2' };
|
||||
const res = await w.webContents.debugger.sendCommand('Runtime.evaluate', params);
|
||||
|
||||
expect(res.wasThrown).to.be.undefined()
|
||||
expect(res.result.value).to.equal(6)
|
||||
expect(res.wasThrown).to.be.undefined();
|
||||
expect(res.result.value).to.equal(6);
|
||||
|
||||
w.webContents.debugger.detach()
|
||||
})
|
||||
w.webContents.debugger.detach();
|
||||
});
|
||||
|
||||
it('fires message event', done => {
|
||||
const url = process.platform !== 'win32'
|
||||
? `file://${path.join(fixtures, 'pages', 'a.html')}`
|
||||
: `file:///${path.join(fixtures, 'pages', 'a.html').replace(/\\/g, '/')}`
|
||||
w.webContents.loadURL(url)
|
||||
: `file:///${path.join(fixtures, 'pages', 'a.html').replace(/\\/g, '/')}`;
|
||||
w.webContents.loadURL(url);
|
||||
|
||||
try {
|
||||
w.webContents.debugger.attach()
|
||||
w.webContents.debugger.attach();
|
||||
} catch (err) {
|
||||
done(`unexpected error : ${err}`)
|
||||
done(`unexpected error : ${err}`);
|
||||
}
|
||||
|
||||
w.webContents.debugger.on('message', (e, method, params) => {
|
||||
if (method === 'Console.messageAdded') {
|
||||
try {
|
||||
expect(params.message.level).to.equal('log')
|
||||
expect(params.message.url).to.equal(url)
|
||||
expect(params.message.text).to.equal('a')
|
||||
done()
|
||||
expect(params.message.level).to.equal('log');
|
||||
expect(params.message.url).to.equal(url);
|
||||
expect(params.message.text).to.equal('a');
|
||||
done();
|
||||
} catch (e) {
|
||||
done(e)
|
||||
done(e);
|
||||
} finally {
|
||||
w.webContents.debugger.detach()
|
||||
w.webContents.debugger.detach();
|
||||
}
|
||||
}
|
||||
})
|
||||
w.webContents.debugger.sendCommand('Console.enable')
|
||||
})
|
||||
});
|
||||
w.webContents.debugger.sendCommand('Console.enable');
|
||||
});
|
||||
|
||||
it('returns error message when command fails', async () => {
|
||||
w.webContents.loadURL('about:blank')
|
||||
w.webContents.debugger.attach()
|
||||
w.webContents.loadURL('about:blank');
|
||||
w.webContents.debugger.attach();
|
||||
|
||||
const promise = w.webContents.debugger.sendCommand('Test')
|
||||
await expect(promise).to.be.eventually.rejectedWith(Error, "'Test' wasn't found")
|
||||
const promise = w.webContents.debugger.sendCommand('Test');
|
||||
await expect(promise).to.be.eventually.rejectedWith(Error, "'Test' wasn't found");
|
||||
|
||||
w.webContents.debugger.detach()
|
||||
})
|
||||
w.webContents.debugger.detach();
|
||||
});
|
||||
|
||||
// TODO(deepak1556): Fix and enable with upgrade
|
||||
it.skip('handles valid unicode characters in message', (done) => {
|
||||
try {
|
||||
w.webContents.debugger.attach()
|
||||
w.webContents.debugger.attach();
|
||||
} catch (err) {
|
||||
done(`unexpected error : ${err}`)
|
||||
done(`unexpected error : ${err}`);
|
||||
}
|
||||
|
||||
let requestId : number
|
||||
let requestId : number;
|
||||
w.webContents.debugger.on('message', (event, method, params) => {
|
||||
if (method === 'Network.responseReceived' &&
|
||||
params.response.url.startsWith('http://127.0.0.1')) {
|
||||
requestId = params.requestId
|
||||
requestId = params.requestId;
|
||||
} else if (method === 'Network.loadingFinished' &&
|
||||
params.requestId === requestId) {
|
||||
w.webContents.debugger.sendCommand('Network.getResponseBody', {
|
||||
requestId: params.requestId
|
||||
}).then(data => {
|
||||
expect(data.body).to.equal('\u0024')
|
||||
done()
|
||||
}).catch(result => done(result))
|
||||
expect(data.body).to.equal('\u0024');
|
||||
done();
|
||||
}).catch(result => done(result));
|
||||
}
|
||||
})
|
||||
});
|
||||
|
||||
server = http.createServer((req, res) => {
|
||||
res.setHeader('Content-Type', 'text/plain; charset=utf-8')
|
||||
res.end('\u0024')
|
||||
})
|
||||
res.setHeader('Content-Type', 'text/plain; charset=utf-8');
|
||||
res.end('\u0024');
|
||||
});
|
||||
|
||||
server.listen(0, '127.0.0.1', () => {
|
||||
w.webContents.debugger.sendCommand('Network.enable')
|
||||
w.loadURL(`http://127.0.0.1:${(server.address() as AddressInfo).port}`)
|
||||
})
|
||||
})
|
||||
w.webContents.debugger.sendCommand('Network.enable');
|
||||
w.loadURL(`http://127.0.0.1:${(server.address() as AddressInfo).port}`);
|
||||
});
|
||||
});
|
||||
|
||||
it('does not crash for invalid unicode characters in message', (done) => {
|
||||
try {
|
||||
w.webContents.debugger.attach()
|
||||
w.webContents.debugger.attach();
|
||||
} catch (err) {
|
||||
done(`unexpected error : ${err}`)
|
||||
done(`unexpected error : ${err}`);
|
||||
}
|
||||
|
||||
w.webContents.debugger.on('message', (event, method) => {
|
||||
// loadingFinished indicates that page has been loaded and it did not
|
||||
// crash because of invalid UTF-8 data
|
||||
if (method === 'Network.loadingFinished') {
|
||||
done()
|
||||
done();
|
||||
}
|
||||
})
|
||||
});
|
||||
|
||||
server = http.createServer((req, res) => {
|
||||
res.setHeader('Content-Type', 'text/plain; charset=utf-8')
|
||||
res.end('\uFFFF')
|
||||
})
|
||||
res.setHeader('Content-Type', 'text/plain; charset=utf-8');
|
||||
res.end('\uFFFF');
|
||||
});
|
||||
|
||||
server.listen(0, '127.0.0.1', () => {
|
||||
w.webContents.debugger.sendCommand('Network.enable')
|
||||
w.loadURL(`http://127.0.0.1:${(server.address() as AddressInfo).port}`)
|
||||
})
|
||||
})
|
||||
})
|
||||
})
|
||||
w.webContents.debugger.sendCommand('Network.enable');
|
||||
w.loadURL(`http://127.0.0.1:${(server.address() as AddressInfo).port}`);
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue