mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Fix "Object has been destroyed" error in "page-title-updated" event

Browse source 
Close #4249.
This commit is contained in:
Cheng Zhao 2016-01-30 12:20:28 +08:00
parent 899294a040
commit 5d16257c2d
1 changed files with 10 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

18
atom/browser/api/lib/browser-window.js
View file

@ -55,14 +55,16 @@ BrowserWindow.prototype._init = function() {
})(this)); })(this));
// Change window title to page title. // Change window title to page title.
this.webContents.on('page-title-updated', (function(_this) { this.webContents.on('page-title-updated', (event, title) => {
return function(event, title) { // The page-title-updated event is not emitted immediately (see #3645), so
_this.emit('page-title-updated', event, title); // when the callback is called the BrowserWindow might have been closed.
if (!event.defaultPrevented) { if (this.isDestroyed())
return _this.setTitle(title); return;
} // Route the event to BrowserWindow.
}; this.emit('page-title-updated', event, title);
})(this)); if (!event.defaultPrevented)
this.setTitle(title);
});
// Sometimes the webContents doesn't get focus when window is shown, so we have // Sometimes the webContents doesn't get focus when window is shown, so we have
// to force focusing on webContents in this case. The safest way is to focus it // to force focusing on webContents in this case. The safest way is to focus it