mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: do not DCHECK non-const methods (#20833)

Browse source
This commit is contained in:
Shelley Vohr 2019-10-29 13:35:38 -07:00 committed by GitHub
parent 79d3901859
commit 5d00494f8d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
shell/renderer/atom_renderer_client.cc
View file

@ -121,7 +121,9 @@ void AtomRendererClient::DidCreateScriptContext(
node::tracing::TraceEventHelper::SetAgent(node::CreateAgent());
// Setup node environment for each window.
DCHECK(node::InitializeContext(renderer_context));
bool initialized = node::InitializeContext(renderer_context);
CHECK(initialized);
node::Environment* env =
node_bindings_->CreateEnvironment(renderer_context, nullptr, true);

3
shell/renderer/web_worker_observer.cc
View file

@ -48,7 +48,8 @@ void WebWorkerObserver::ContextCreated(v8::Local<v8::Context> worker_context) {
node_bindings_->PrepareMessageLoop();
// Setup node environment for each window.
DCHECK(node::InitializeContext(worker_context));
bool initialized = node::InitializeContext(worker_context);
CHECK(initialized);
node::Environment* env =
node_bindings_->CreateEnvironment(worker_context, nullptr, true);