mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: reduce code duplication in gin_helper::Promise (33-x-y) (#43778)

Browse source 
refactor: reduce code duplication in gin_helper::Promise (#43716)

* refactor: move scope scaffolding into SettletScope

idea stolen from SpellCheckScope

* refactor: move impl of PromiseBase::RejectPromise() to the cc file

* chore: remove unused #include

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This commit is contained in:
Charles Kerr 2024-09-19 06:01:13 -05:00 • committed by GitHub
parent 68869c18cd
commit 5c92ea76e9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 85 additions and 87 deletions
Download patch file Download diff file Expand all files Collapse all files

1
shell/browser/api/electron_api_system_preferences_win.cc
View file

@ -16,6 +16,7 @@
#include "base/win/windows_types.h"
#include "base/win/wrapped_window_proc.h"
#include "shell/common/color_util.h"
#include "shell/common/process_util.h"
#include "ui/gfx/color_utils.h"
#include "ui/gfx/win/hwnd_util.h"

1
shell/browser/api/electron_api_web_contents.cc
View file

@ -125,6 +125,7 @@
#include "shell/common/gin_converters/value_converter.h"
#include "shell/common/gin_helper/dictionary.h"
#include "shell/common/gin_helper/error_thrower.h"
#include "shell/common/gin_helper/locker.h"
#include "shell/common/gin_helper/object_template_builder.h"
#include "shell/common/gin_helper/promise.h"
#include "shell/common/language_util.h"

1
shell/browser/electron_crypto_module_delegate_nss.cc
View file

@ -4,6 +4,7 @@
#include "shell/browser/electron_crypto_module_delegate_nss.h"
#include "content/public/browser/browser_thread.h"
#include "crypto/nss_crypto_module_delegate.h"
#include "shell/browser/api/electron_api_app.h"
#include "shell/browser/javascript_environment.h"

2
shell/browser/serial/serial_chooser_controller.cc
View file

@ -7,7 +7,7 @@
#include <algorithm>
#include <utility>
#include "base/files/file_path.h"
#include "base/containers/contains.h"
#include "base/functional/bind.h"
#include "base/strings/stringprintf.h"
#include "content/public/browser/web_contents.h"

1
shell/browser/ui/devtools_manager_delegate.cc
View file

@ -12,6 +12,7 @@
#include "base/functional/bind.h"
#include "base/path_service.h"
#include "base/strings/string_number_conversions.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/devtools_agent_host.h"
#include "content/public/browser/devtools_frontend_host.h"
#include "content/public/browser/devtools_socket_factory.h"