From 5c8c31c93d1c5b4ac4c66b7b921be94681eb592f Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Fri, 14 Sep 2018 16:38:44 +1000 Subject: [PATCH] spec: update 'BrowserWindow.fromBrowserView(browserView) returns undefined if not attached - returns undefined if not attached' to match docs (null not undefined) --- spec/api-browser-window-spec.js | 2 +- spec/assert-helpers.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/spec/api-browser-window-spec.js b/spec/api-browser-window-spec.js index dddaa2aecadb..7d1013046a45 100644 --- a/spec/api-browser-window-spec.js +++ b/spec/api-browser-window-spec.js @@ -1014,7 +1014,7 @@ describe('BrowserWindow module', () => { it('returns undefined if not attached', () => { w.setBrowserView(null) - assert.strictEqual(BrowserWindow.fromBrowserView(bv), undefined) + assert.strictEqual(BrowserWindow.fromBrowserView(bv), null) }) }) diff --git a/spec/assert-helpers.js b/spec/assert-helpers.js index b180f5b95d4b..10c66bce6115 100644 --- a/spec/assert-helpers.js +++ b/spec/assert-helpers.js @@ -3,5 +3,5 @@ function resolverGetters (...args) { } module.exports = { - resolverGetters, -} \ No newline at end of file + resolverGetters +}