mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: -Wunsafe-buffer-usage warning in V8Serializer::Serialize() (#43676)

Browse source 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2024-09-10 19:00:33 -05:00 committed by GitHub
parent 017ba5bf46
commit 5b933e941e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
shell/common/v8_value_serializer.cc
View file

@ -49,10 +49,12 @@ class V8Serializer : public v8::ValueSerializer::Delegate {
} }
DCHECK(wrote_value); DCHECK(wrote_value);
std::pair<uint8_t*, size_t> buffer = serializer_.Release(); const auto [data_bytes, data_len] = serializer_.Release();
DCHECK_EQ(buffer.first, data_.data()); DCHECK_EQ(std::data(data_), data_bytes);
out->encoded_message = base::make_span(buffer.first, buffer.second); DCHECK_GE(std::size(data_), data_len);
data_.resize(data_len);
out->owned_encoded_message = std::move(data_); out->owned_encoded_message = std::move(data_);
out->encoded_message = out->owned_encoded_message;
out->sender_agent_cluster_id = out->sender_agent_cluster_id =
blink::WebMessagePort::GetEmbedderAgentClusterID(); blink::WebMessagePort::GetEmbedderAgentClusterID();