mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix win/linux compile (again)

Browse source
This commit is contained in:
Gabriel Handford 2016-11-02 16:36:01 -07:00 committed by Cheng Zhao
parent f0ca9dff81
commit 5b260dbee3
2 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
atom/common/platform_util_linux.cc
View file

@ -93,6 +93,7 @@ void OpenExternal(const GURL& url, bool activate,
const OpenExternalCallback& callback) { const OpenExternalCallback& callback) {
// TODO(gabriel): Implement async open if callback is specified // TODO(gabriel): Implement async open if callback is specified
bool opened = OpenExternal(url, activate); bool opened = OpenExternal(url, activate);
v8::Isolate* isolate = v8::Isolate::GetCurrent();
if (!opened) { if (!opened) {
callback.Run(v8::Exception::Error( callback.Run(v8::Exception::Error(
v8::String::NewFromUtf8(isolate, "Failed to open"))); v8::String::NewFromUtf8(isolate, "Failed to open")));

1
atom/common/platform_util_win.cc
View file

@ -320,6 +320,7 @@ void OpenExternal(const base::string16& url, bool activate,
const OpenExternalCallback& callback) { const OpenExternalCallback& callback) {
// TODO(gabriel): Implement async open if callback is specified // TODO(gabriel): Implement async open if callback is specified
bool opened = OpenExternal(url, activate); bool opened = OpenExternal(url, activate);
v8::Isolate* isolate = v8::Isolate::GetCurrent();
if (!opened) { if (!opened) {
callback.Run(v8::Exception::Error( callback.Run(v8::Exception::Error(
v8::String::NewFromUtf8(isolate, "Failed to open"))); v8::String::NewFromUtf8(isolate, "Failed to open")));