chore: bump chromium to 129.0.6630.0 (main) (#43087)

* chore: bump chromium in DEPS to 129.0.6623.0

* chore: update mas_avoid_private_macos_api_usage.patch.patch

remove the changes to media/audio/mac/audio_manager_mac.cc,
since upstream has also made this change now.

Xref: 5738654

* chore: update fix_disable_scope_reuse_associated_dchecks.patch

We had been removing a couple of `DCHECK`. Upstream changed their
code to limit when these `DCHECK`s get called, so let's see if our
change is still needed.

Xref: 5739076

* chore: e patches all

* Bump the Chrome macOS deployment target to 11.0

Xref: 5734361

BREAKING CHANGE: Bump the Chrome macOS deployment target to 11.0

* src: stop using deprecated fields of `v8::FastApiCallbackOptions`

Xref: d0000b118d
Xref: 5741336
Xref: 5741199

* fixup! chore: update fix_disable_scope_reuse_associated_dchecks.patch

chore: re-disable DCHECKs

yep, it is still needed

* refactor use non-deprecated variant of openApplicationAtURL

old version is deprecated now in macOS 11

Xref: 1534810-launchapplicationaturl

Xref: 3172700-openapplicationaturl

* chore: bump chromium in DEPS to 129.0.6626.0

* chore: e patches all

* chore: disable NSUserNotification deprecation errors

* chore: disable NSWindowStyleMaskTexturedBackground deprecation errors

Xref: https://github.com/electron/electron/issues/43125

* chore: disable deprecation errors in platform_util_mac.mm

* chore: disable launchApplication deprecation errors

* chore: bump chromium in DEPS to 129.0.6630.0

* chore: update refactor_expose_file_system_access_blocklist.patch

apply patch manually due to context shear

Xref: 5745444

* chore: update deps_add_v8_object_setinternalfieldfornodecore.patch

no manual changes. patch applied with fuzz 1 (offset -5 lines)

* chore: e patches all

* fix: add clang_x64_v8_arm64/snapshot_blob.bin to the zip manifest

Xref: 5746173

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>

shell/app/electron_login_helper.mm

@@ -4,6 +4,12 @@
 
 #import <Cocoa/Cocoa.h>
 
+// launchApplication is deprecated; should be migrated to
+// [NSWorkspace openApplicationAtURL:configuration:completionHandler:]
+// UserNotifications.frameworks API
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+
 int main(int argc, char* argv[]) {
   @autoreleasepool {
     NSArray* pathComponents =
@@ -11,7 +17,11 @@ int main(int argc, char* argv[]) {
     pathComponents = [pathComponents
         subarrayWithRange:NSMakeRange(0, [pathComponents count] - 4)];
     NSString* path = [NSString pathWithComponents:pathComponents];
+
     [[NSWorkspace sharedWorkspace] launchApplication:path];
     return 0;
   }
 }
+
+// -Wdeprecated-declarations
+#pragma clang diagnostic pop

shell/browser/mac/electron_application_delegate.mm

@@ -68,6 +68,11 @@ static NSDictionary* UNNotificationResponseToNSDictionary(
   electron::Browser::Get()->WillFinishLaunching();
 }
 
+// NSUserNotification is deprecated; all calls should be replaced with
+// UserNotifications.frameworks API
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+
 - (void)applicationDidFinishLaunching:(NSNotification*)notify {
   NSObject* user_notification =
       [notify userInfo][NSApplicationLaunchUserNotificationKey];
@@ -95,6 +100,9 @@ static NSDictionary* UNNotificationResponseToNSDictionary(
       electron::NSDictionaryToValue(notification_info));
 }
 
+// -Wdeprecated-declarations
+#pragma clang diagnostic pop
+
 - (void)applicationDidBecomeActive:(NSNotification*)notification {
   electron::Browser::Get()->DidBecomeActive();
 }

shell/browser/native_window_mac.mm

@@ -219,6 +219,11 @@ NativeWindowMac::NativeWindowMac(const gin_helper::Dictionary& options,
   if (!rounded_corner && !has_frame())
     styleMask = NSWindowStyleMaskBorderless;
 
+// TODO: remove NSWindowStyleMaskTexturedBackground.
+// https://github.com/electron/electron/issues/43125
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+
   if (minimizable)
     styleMask |= NSWindowStyleMaskMiniaturizable;
   if (closable)
@@ -228,6 +233,9 @@ NativeWindowMac::NativeWindowMac(const gin_helper::Dictionary& options,
   if (!useStandardWindow || transparent() || !has_frame())
     styleMask |= NSWindowStyleMaskTexturedBackground;
 
+// -Wdeprecated-declarations
+#pragma clang diagnostic pop
+
   // Create views::Widget and assign window_ with it.
   // TODO(zcbenz): Get rid of the window_ in future.
   views::Widget::InitParams params(

shell/browser/notifications/mac/cocoa_notification.h

@@ -14,6 +14,11 @@
 
 namespace electron {
 
+// NSUserNotification is deprecated; all calls should be replaced with
+// UserNotifications.frameworks API
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+
 class CocoaNotification : public Notification {
  public:
   CocoaNotification(NotificationDelegate* delegate,
@@ -40,6 +45,9 @@ class CocoaNotification : public Notification {
   unsigned action_index_;
 };
 
+// -Wdeprecated-declarations
+#pragma clang diagnostic pop
+
 }  // namespace electron
 
 #endif  // ELECTRON_SHELL_BROWSER_NOTIFICATIONS_MAC_COCOA_NOTIFICATION_H_

shell/browser/notifications/mac/cocoa_notification.mm

@@ -14,6 +14,11 @@
 #include "shell/browser/notifications/notification_presenter.h"
 #include "skia/ext/skia_utils_mac.h"
 
+// NSUserNotification is deprecated; we need to use the
+// UserNotifications.frameworks API instead
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+
 namespace electron {
 
 CocoaNotification::CocoaNotification(NotificationDelegate* delegate,

shell/browser/notifications/mac/notification_center_delegate.mm

@@ -10,6 +10,11 @@
 #include "shell/browser/notifications/mac/cocoa_notification.h"
 #include "shell/browser/notifications/mac/notification_presenter_mac.h"
 
+// NSUserNotification is deprecated; we need to use the
+// UserNotifications.frameworks API instead
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+
 @implementation NotificationCenterDelegate
 
 - (instancetype)initWithPresenter:

shell/browser/notifications/mac/notification_presenter_mac.h

@@ -13,6 +13,11 @@ namespace electron {
 
 class CocoaNotification;
 
+// NSUserNotification is deprecated; all calls should be replaced with
+// UserNotifications.frameworks API
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+
 class NotificationPresenterMac : public NotificationPresenter {
  public:
   CocoaNotification* GetNotification(NSUserNotification* ns_notification);
@@ -28,6 +33,9 @@ class NotificationPresenterMac : public NotificationPresenter {
   NotificationCenterDelegate* __strong notification_center_delegate_;
 };
 
+// -Wdeprecated-declarations
+#pragma clang diagnostic pop
+
 }  // namespace electron
 
 #endif  // ELECTRON_SHELL_BROWSER_NOTIFICATIONS_MAC_NOTIFICATION_PRESENTER_MAC_H_

shell/browser/notifications/mac/notification_presenter_mac.mm

@@ -9,6 +9,11 @@
 #include "shell/browser/notifications/mac/cocoa_notification.h"
 #include "shell/browser/notifications/mac/notification_center_delegate.h"
 
+// NSUserNotification is deprecated; we need to use the
+// UserNotifications.frameworks API instead
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+
 namespace electron {
 
 // static

shell/browser/ui/cocoa/electron_inspectable_web_contents_view.mm

@@ -154,6 +154,11 @@
   }
 }
 
+// TODO: remove NSWindowStyleMaskTexturedBackground.
+// https://github.com/electron/electron/issues/43125
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+
 - (void)setIsDocked:(BOOL)docked activate:(BOOL)activate {
   // Revert to no-devtools state.
   [self setDevToolsVisible:NO activate:NO];
@@ -196,6 +201,9 @@
   [self setDevToolsVisible:YES activate:activate];
 }
 
+// -Wdeprecated-declarations
+#pragma clang diagnostic pop
+
 - (void)setContentsResizingStrategy:
     (const DevToolsContentsResizingStrategy&)strategy {
   strategy_.CopyFrom(strategy);

shell/common/platform_util_mac.mm

@@ -25,6 +25,11 @@
 #include "ui/views/widget/widget.h"
 #include "url/gurl.h"
 
+// platform_util_mac.mm uses a lot of deprecated API.
+// https://github.com/electron/electron/issues/43126
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+
 namespace {
 
 // This may be called from a global dispatch queue, the methods used here are
@@ -78,6 +83,9 @@ std::string OpenPathOnThread(const base::FilePath& full_path) {
   return success ? "" : "Failed to open path";
 }
 
+// -Wdeprecated-declarations
+#pragma clang diagnostic pop
+
 // https://developer.apple.com/documentation/servicemanagement/1561515-service_management_errors?language=objc
 std::string GetLaunchStringForError(NSError* error) {
   if (@available(macOS 13, *)) {

shell/utility/electron_content_utility_client.cc

@@ -95,7 +95,7 @@ ElectronContentUtilityClient::~ElectronContentUtilityClient() = default;
 void ElectronContentUtilityClient::ExposeInterfacesToBrowser(
     mojo::BinderMap* binders) {
 #if BUILDFLAG(IS_WIN)
-  auto& cmd_line = *base::CommandLine::ForCurrentProcess();
+  const auto& cmd_line = *base::CommandLine::ForCurrentProcess();
   auto sandbox_type = sandbox::policy::SandboxTypeFromCommandLine(cmd_line);
   utility_process_running_elevated_ =
       sandbox_type == sandbox::mojom::Sandbox::kNoSandboxAndElevatedPrivileges;