mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: finish replacing assert with expect in tests (#18215)

Browse source 
* spec: replace assert with expect in api-browser-view-spec.js

* spec: replace assert with expect in api-touch-bar-spec.js

* spec: replace assert with expect in api-web-frame-spec.js

* spec: replace assert with expect in api-web-contents-view-spec.js

* spec: replace assert with expect in security-warnings-spec.js

* spec: replace assert with expect in api-menu-item-spec.js

* spec: replace assert with expect in api-web-request-spec.js

* spec: replace assert with expect in api-remote-spec.js

* spec: replace assert with expect in api-session-spec.js

* spec: replace assert with expect in api-system-preferences-spec.js

* spec: replace assert with expect in api-browser-window-spec.js

* spec: replace assert with expect in webview-spec.js

* spec: replace assert with expect in api-net-spec.js

* spec: replace assert with expect in api-protocol-spec.js

* spec: replace assert with expect api-web-contents-spec.js

* spec: replace assert with expect in api-shell-spec.js

* spec: replace assert with expect in modules-spec.js

* spec: replace assert with expect in chromium-spec.js

* spec: replace assert with expect in api-crash-reporter-spec.js

* spec: replace assert with expect in asar-spec.js

* spec: rename assert-helpers to expect-helpers

* address PR feedback
This commit is contained in:
Milan Burda 2019-05-20 19:04:18 +02:00 • committed by Charles Kerr
parent dbb8617214
commit 5a7b56b042
22 changed files with 1546 additions and 1591 deletions
Download patch file Download diff file Expand all files Collapse all files

18
spec/api-touch-bar-spec.js
View file

@ -1,36 +1,36 @@
const assert = require('assert')
const path = require('path')
const { BrowserWindow, TouchBar } = require('electron').remote
const { closeWindow } = require('./window-helpers')
const { expect } = require('chai')
const { TouchBarButton, TouchBarColorPicker, TouchBarGroup } = TouchBar
const { TouchBarLabel, TouchBarPopover, TouchBarScrubber, TouchBarSegmentedControl, TouchBarSlider, TouchBarSpacer } = TouchBar
describe('TouchBar module', () => {
it('throws an error when created without an options object', () => {
assert.throws(() => {
expect(() => {
const touchBar = new TouchBar()
touchBar.toString()
}, /Must specify options object as first argument/)
}).to.throw('Must specify options object as first argument')
})
it('throws an error when created with invalid items', () => {
assert.throws(() => {
expect(() => {
const touchBar = new TouchBar({ items: [1, true, {}, []] })
touchBar.toString()
}, /Each item must be an instance of TouchBarItem/)
}).to.throw('Each item must be an instance of TouchBarItem')
})
it('throws an error when an invalid escape item is set', () => {
assert.throws(() => {
expect(() => {
const touchBar = new TouchBar({ items: [], escapeItem: 'esc' })
touchBar.toString()
}, /Escape item must be an instance of TouchBarItem/)
}).to.throw('Escape item must be an instance of TouchBarItem')
assert.throws(() => {
expect(() => {
const touchBar = new TouchBar({ items: [] })
touchBar.escapeItem = 'esc'
}, /Escape item must be an instance of TouchBarItem/)
}).to.throw('Escape item must be an instance of TouchBarItem')
})
describe('BrowserWindow behavior', () => {