mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feat!: remove support for ProtocolResponse.session null value (#46264)

Browse source 
BREAKING CHANGE

This was deprecated in f7ba0d3b & is now being removed for Electron 37.
This commit is contained in:
Charles Kerr 2025-04-01 08:52:12 -05:00 • committed by GitHub
parent 0e687d3082
commit 5a6f1ede6a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 19 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

20
shell/browser/net/electron_url_loader_factory.cc
View file

@ -13,7 +13,6 @@
#include "base/containers/fixed_flat_map.h"
#include "base/strings/string_number_conversions.h"
#include "base/task/sequenced_task_runner.h"
#include "base/uuid.h"
#include "base/values.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/storage_partition.h"
@ -671,20 +670,11 @@ void ElectronURLLoaderFactory::StartLoadingHttp(
request->method != net::HttpRequestHeaders::kHeadMethod)
dict.Get("uploadData", &upload_data);
auto* browser_context = ElectronBrowserContext::GetDefaultBrowserContext();
v8::Local<v8::Value> value;
if (dict.Get("session", &value)) {
if (value->IsNull()) {
browser_context = ElectronBrowserContext::From(
base::Uuid::GenerateRandomV4().AsLowercaseString(), true);
} else {
gin::Handle<api::Session> session;
if (gin::ConvertFromV8(dict.isolate(), value, &session) &&
!session.IsEmpty()) {
browser_context = session->browser_context();
}
}
}
gin::Handle<api::Session> session;
auto* browser_context =
dict.Get("session", &session) && !session.IsEmpty()
? session->browser_context()
: ElectronBrowserContext::GetDefaultBrowserContext();
new URLPipeLoader(
browser_context->GetURLLoaderFactory(), std::move(request),