mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: fix promisify helper (#16544)

Browse source 
* chore: fix promise deprecation helper

* fix deprecations

* update deprecation tests
This commit is contained in:
Shelley Vohr 2019-01-25 14:23:24 -08:00 • committed by GitHub
parent 63bf370cc0
commit 5a35c3a279
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
12 changed files with 65 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

14
spec/api-protocol-spec.js
View file

@ -680,14 +680,14 @@ describe('protocol module', () => {
})
})
describe('protocol.isProtocolHandled', (done) => {
describe('protocol.isProtocolHandled', () => {
it('returns true for about:', async () => {
const result = await protocol.isProtocolHandled('about')
assert.strictEqual(result, true)
})
// TODO(codebytere): remove when promisification is complete
it('returns true for about: (callback)', () => {
it('returns true for about: (callback)', (done) => {
protocol.isProtocolHandled('about', (result) => {
assert.strictEqual(result, true)
done()
@ -700,7 +700,7 @@ describe('protocol module', () => {
})
// TODO(codebytere): remove when promisification is complete
it('returns true for file: (callback)', () => {
it('returns true for file: (callback)', (done) => {
protocol.isProtocolHandled('file', (result) => {
assert.strictEqual(result, true)
done()
@ -722,7 +722,7 @@ describe('protocol module', () => {
assert.strictEqual(result, false)
})
it('returns true for custom protocol', () => {
it('returns true for custom protocol', (done) => {
const emptyHandler = (request, callback) => callback()
protocol.registerStringProtocol(protocolName, emptyHandler, async (error) => {
assert.strictEqual(error, null)
@ -733,7 +733,7 @@ describe('protocol module', () => {
})
// TODO(codebytere): remove when promisification is complete
it('returns true for custom protocol (callback)', () => {
it('returns true for custom protocol (callback)', (done) => {
const emptyHandler = (request, callback) => callback()
protocol.registerStringProtocol(protocolName, emptyHandler, (error) => {
assert.strictEqual(error, null)
@ -744,7 +744,7 @@ describe('protocol module', () => {
})
})
it('returns true for intercepted protocol', () => {
it('returns true for intercepted protocol', (done) => {
const emptyHandler = (request, callback) => callback()
protocol.interceptStringProtocol('http', emptyHandler, async (error) => {
assert.strictEqual(error, null)
@ -755,7 +755,7 @@ describe('protocol module', () => {
})
// TODO(codebytere): remove when promisification is complete
it('returns true for intercepted protocol (callback)', () => {
it('returns true for intercepted protocol (callback)', (done) => {
const emptyHandler = (request, callback) => callback()
protocol.interceptStringProtocol('http', emptyHandler, (error) => {
assert.strictEqual(error, null)