mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: fix promisify helper (#16544)

Browse source 
* chore: fix promise deprecation helper

* fix deprecations

* update deprecation tests
This commit is contained in:
Shelley Vohr 2019-01-25 14:23:24 -08:00 • committed by GitHub
parent 63bf370cc0
commit 5a35c3a279
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
12 changed files with 65 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

6
spec/api-app-spec.js
View file

@ -859,7 +859,7 @@ describe('app module', () => {
})
// TODO(codebytere): remove when promisification is complete
it('fetches a non-empty icon (callback)', () => {
it('fetches a non-empty icon (callback)', (done) => {
app.getFileIcon(iconPath, (icon) => {
expect(icon.isEmpty()).to.be.false()
done()
@ -875,7 +875,7 @@ describe('app module', () => {
})
// TODO(codebytere): remove when promisification is complete
it('fetches normal icon size by default (callback)', () => {
it('fetches normal icon size by default (callback)', (done) => {
app.getFileIcon(iconPath, (icon) => {
const size = icon.getSize()
@ -903,7 +903,7 @@ describe('app module', () => {
})
// TODO(codebytere): remove when promisification is complete
it('fetches a normal icon (callback)', () => {
it('fetches a normal icon (callback)', (done) => {
app.getFileIcon(iconPath, { size: 'normal' }, (icon) => {
const size = icon.getSize()