mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

perf: prefer GURL string_view getters (#43443)

Browse source 
* chore: avoid double-call to url.scheme() in WebContentsZoomController::SetZoomMode()

* perf: use gurl.scheme_piece() in GetAppInfoHelperForProtocol()

* perf: use gurl.scheme_piece() in Browser::GetApplicationNameForProtocol()

* refactor: add std::less<> to HandlersMap

This lets us search it using string_view keys

* refactor: ProtocolRegistry::FindRegistered() now takes a std::string_view

* perf: use gurl.scheme_piece() in InspectableWebContents::LoadNetworkResource()

* refactor: ProtocolRegistry::FindIntercepted() now takes a std::string_view

* perf: use gurl.scheme_piece() in SimpleURLLoaderWrapper::GetURLLoaderFactoryForURL()

* perf: use gurl.scheme_piece() in ProxyingURLLoaderFactory::CreateLoaderAndStart()

* perf: use gurl.host_piece() in ElectronWebUIControllerFactory::GetWebUIType()

* perf: use gurl.host_piece() in ElectronWebUIControllerFactory::CreateWebUIControllerForURL()
This commit is contained in:
Charles Kerr 2024-08-23 17:15:45 -05:00 • committed by GitHub
parent 7f34b0e6f5
commit 5a1eeea102
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 26 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

5
shell/browser/protocol_registry.h
View file

@ -6,6 +6,7 @@
#define ELECTRON_SHELL_BROWSER_PROTOCOL_REGISTRY_H_
#include <string>
#include <string_view>
#include "content/public/browser/content_browser_client.h"
#include "shell/browser/net/electron_url_loader_factory.h"
@ -40,7 +41,7 @@ class ProtocolRegistry {
bool UnregisterProtocol(const std::string& scheme);
[[nodiscard]] const HandlersMap::mapped_type* FindRegistered(
const std::string& scheme) const;
std::string_view scheme) const;
bool InterceptProtocol(ProtocolType type,
const std::string& scheme,
@ -48,7 +49,7 @@ class ProtocolRegistry {
bool UninterceptProtocol(const std::string& scheme);
[[nodiscard]] const HandlersMap::mapped_type* FindIntercepted(
const std::string& scheme) const;
std::string_view scheme) const;
private:
friend class ElectronBrowserContext;