perf: prefer GURL string_view getters (#43470)
* chore: avoid double-call to url.scheme() in WebContentsZoomController::SetZoomMode() Co-authored-by: Charles Kerr <charles@charleskerr.com> * perf: use gurl.scheme_piece() in GetAppInfoHelperForProtocol() Co-authored-by: Charles Kerr <charles@charleskerr.com> * perf: use gurl.scheme_piece() in Browser::GetApplicationNameForProtocol() Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: add std::less<> to HandlersMap This lets us search it using string_view keys Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: ProtocolRegistry::FindRegistered() now takes a std::string_view Co-authored-by: Charles Kerr <charles@charleskerr.com> * perf: use gurl.scheme_piece() in InspectableWebContents::LoadNetworkResource() Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: ProtocolRegistry::FindIntercepted() now takes a std::string_view Co-authored-by: Charles Kerr <charles@charleskerr.com> * perf: use gurl.scheme_piece() in SimpleURLLoaderWrapper::GetURLLoaderFactoryForURL() Co-authored-by: Charles Kerr <charles@charleskerr.com> * perf: use gurl.scheme_piece() in ProxyingURLLoaderFactory::CreateLoaderAndStart() Co-authored-by: Charles Kerr <charles@charleskerr.com> * perf: use gurl.host_piece() in ElectronWebUIControllerFactory::GetWebUIType() Co-authored-by: Charles Kerr <charles@charleskerr.com> * perf: use gurl.host_piece() in ElectronWebUIControllerFactory::CreateWebUIControllerForURL() Co-authored-by: Charles Kerr <charles@charleskerr.com> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
parent
5829d2a09a
commit
5a1bab7c3a
10 changed files with 26 additions and 19 deletions
|
@ -96,7 +96,7 @@ bool IsValidCustomProtocol(const std::wstring& scheme) {
|
|||
// (https://docs.microsoft.com/en-us/windows/win32/api/shlwapi/ne-shlwapi-assocstr)
|
||||
// and returns the application name, icon and path that handles the protocol.
|
||||
std::wstring GetAppInfoHelperForProtocol(ASSOCSTR assoc_str, const GURL& url) {
|
||||
const std::wstring url_scheme = base::ASCIIToWide(url.scheme());
|
||||
const std::wstring url_scheme = base::ASCIIToWide(url.scheme_piece());
|
||||
if (!IsValidCustomProtocol(url_scheme))
|
||||
return std::wstring();
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue