mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Notification: pass tag to Show method

Browse source
This commit is contained in:
Marco Trevisan (Treviño) 2016-04-13 05:31:56 +02:00
parent 11685faffa
commit 59ed6ad413
8 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
brightray/browser/linux/libnotify_notification.cc
View file

@ -88,6 +88,7 @@ LibnotifyNotification::~LibnotifyNotification() {
void LibnotifyNotification::Show(const base::string16& title, void LibnotifyNotification::Show(const base::string16& title,
const base::string16& body, const base::string16& body,
const std::string& tag,
const GURL& icon_url, const GURL& icon_url,
const SkBitmap& icon, const SkBitmap& icon,
const bool silent) { const bool silent) {

1
brightray/browser/linux/libnotify_notification.h
View file

@ -22,6 +22,7 @@ class LibnotifyNotification : public Notification {
// Notification: // Notification:
void Show(const base::string16& title, void Show(const base::string16& title,
const base::string16& msg, const base::string16& msg,
const std::string& tag,
const GURL& icon_url, const GURL& icon_url,
const SkBitmap& icon, const SkBitmap& icon,
const bool silent) override; const bool silent) override;

1
brightray/browser/mac/cocoa_notification.h
View file

@ -22,6 +22,7 @@ class CocoaNotification : public Notification {
// Notification: // Notification:
void Show(const base::string16& title, void Show(const base::string16& title,
const base::string16& msg, const base::string16& msg,
const std::string& tag,
const GURL& icon_url, const GURL& icon_url,
const SkBitmap& icon, const SkBitmap& icon,
const bool silent) override; const bool silent) override;

1
brightray/browser/mac/cocoa_notification.mm
View file

@ -30,6 +30,7 @@ CocoaNotification::~CocoaNotification() {
void CocoaNotification::Show(const base::string16& title, void CocoaNotification::Show(const base::string16& title,
const base::string16& body, const base::string16& body,
const std::string& tag,
const GURL& icon_url, const GURL& icon_url,
const SkBitmap& icon, const SkBitmap& icon,
const bool silent) { const bool silent) {

1
brightray/browser/notification.h
View file

@ -21,6 +21,7 @@ class Notification {
// Shows the notification. // Shows the notification.
virtual void Show(const base::string16& title, virtual void Show(const base::string16& title,
const base::string16& msg, const base::string16& msg,
const std::string& tag,
const GURL& icon_url, const GURL& icon_url,
const SkBitmap& icon, const SkBitmap& icon,
const bool silent) = 0; const bool silent) = 0;

2
brightray/browser/platform_notification_service.cc
View file

@ -37,7 +37,7 @@ void OnWebNotificationAllowed(
auto notification = presenter->CreateNotification(adapter.get()); auto notification = presenter->CreateNotification(adapter.get());
if (notification) { if (notification) {
ignore_result(adapter.release()); // it will release itself automatically. ignore_result(adapter.release()); // it will release itself automatically.
notification->Show(data.title, data.body, data.icon, icon, data.silent); notification->Show(data.title, data.body, data.tag, data.icon, icon, data.silent);
*cancel_callback = base::Bind(&RemoveNotification, notification); *cancel_callback = base::Bind(&RemoveNotification, notification);
} }
} }

1
brightray/browser/win/windows_toast_notification.cc
View file

@ -84,6 +84,7 @@ WindowsToastNotification::~WindowsToastNotification() {
void WindowsToastNotification::Show( void WindowsToastNotification::Show(
const base::string16& title, const base::string16& title,
const base::string16& msg, const base::string16& msg,
const std::string& tag,
const GURL& icon_url, const GURL& icon_url,
const SkBitmap& icon, const SkBitmap& icon,
const bool silent) { const bool silent) {

1
brightray/browser/win/windows_toast_notification.h
View file

@ -41,6 +41,7 @@ class WindowsToastNotification : public Notification {
// Notification: // Notification:
void Show(const base::string16& title, void Show(const base::string16& title,
const base::string16& msg, const base::string16& msg,
const std::string& tag,
const GURL& icon_url, const GURL& icon_url,
const SkBitmap& icon, const SkBitmap& icon,
const bool silent) override; const bool silent) override;