build: ensure runner is defined inside the spec callback (#17664)

This commit is contained in:
Samuel Attard 2019-04-02 18:25:45 -07:00 committed by GitHub
parent dc4fe537ee
commit 59e3164206
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 20 deletions

View file

@ -75,6 +75,8 @@ app.whenReady().then(() => {
walker.on('end', () => { walker.on('end', () => {
const runner = mocha.run(() => { const runner = mocha.run(() => {
// Ensure the callback is called after runner is defined
process.nextTick(() => {
if (isCi && runner.hasOnly) { if (isCi && runner.hasOnly) {
try { try {
throw new Error('A spec contains a call to it.only or describe.only and should be reverted.') throw new Error('A spec contains a call to it.only or describe.only and should be reverted.')
@ -88,3 +90,4 @@ app.whenReady().then(() => {
}) })
}) })
}) })
})

View file

@ -94,6 +94,8 @@
} }
const runner = mocha.run(() => { const runner = mocha.run(() => {
// Ensure the callback is called after runner is defined
setTimeout(() => {
if (isCi && runner.hasOnly) { if (isCi && runner.hasOnly) {
try { try {
throw new Error('A spec contains a call to it.only or describe.only and should be reverted.') throw new Error('A spec contains a call to it.only or describe.only and should be reverted.')
@ -109,6 +111,7 @@
if (isCi) { if (isCi) {
ipcRenderer.send('process.exit', runner.failures) ipcRenderer.send('process.exit', runner.failures)
} }
}, 0)
}) })
}) })
})() })()