mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Use bounds helper in failing specs

Browse source
This commit is contained in:
Kevin Sawicki 2016-09-08 13:46:55 -07:00 • committed by Kevin Sawicki
parent 7494e286d9
commit 59a49f6f96
1 changed files with 9 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

24
spec/api-browser-window-spec.js
View file

@ -273,9 +273,7 @@ describe('browser-window module', function () {
it('sets the window size', function (done) { it('sets the window size', function (done) {
var size = [300, 400] var size = [300, 400]
w.once('resize', function () { w.once('resize', function () {
var newSize = w.getSize() assertBoundsEqual(w.getSize(), size)
assert.equal(newSize[0], size[0])
assert.equal(newSize[1], size[1])
done() done()
}) })
w.setSize(size[0], size[1]) w.setSize(size[0], size[1])
@ -288,12 +286,12 @@ describe('browser-window module', function () {
assert.deepEqual(w.getMaximumSize(), [0, 0]) assert.deepEqual(w.getMaximumSize(), [0, 0])
w.setMinimumSize(100, 100) w.setMinimumSize(100, 100)
assert.deepEqual(w.getMinimumSize(), [100, 100]) assertBoundsEqual(w.getMinimumSize(), [100, 100])
assert.deepEqual(w.getMaximumSize(), [0, 0]) assertBoundsEqual(w.getMaximumSize(), [0, 0])
w.setMaximumSize(900, 600) w.setMaximumSize(900, 600)
assert.deepEqual(w.getMinimumSize(), [100, 100]) assertBoundsEqual(w.getMinimumSize(), [100, 100])
assert.deepEqual(w.getMaximumSize(), [900, 600]) assertBoundsEqual(w.getMaximumSize(), [900, 600])
}) })
}) })
@ -303,9 +301,7 @@ describe('browser-window module', function () {
w.setAspectRatio(1 / 2) w.setAspectRatio(1 / 2)
w.setAspectRatio(0) w.setAspectRatio(0)
w.once('resize', function () { w.once('resize', function () {
var newSize = w.getSize() assertBoundsEqual(w.getSize(), size)
assert.equal(newSize[0], size[0])
assert.equal(newSize[1], size[1])
done() done()
}) })
w.setSize(size[0], size[1]) w.setSize(size[0], size[1])
@ -354,7 +350,7 @@ describe('browser-window module', function () {
it('sets the content size and position', function (done) { it('sets the content size and position', function (done) {
var bounds = {x: 10, y: 10, width: 250, height: 250} var bounds = {x: 10, y: 10, width: 250, height: 250}
w.once('resize', function () { w.once('resize', function () {
assert.deepEqual(w.getContentBounds(), bounds) assertBoundsEqual(w.getContentBounds(), bounds)
done() done()
}) })
w.setContentBounds(bounds) w.setContentBounds(bounds)
@ -515,9 +511,7 @@ describe('browser-window module', function () {
size.width += 100 size.width += 100
size.height += 100 size.height += 100
w.setSize(size.width, size.height) w.setSize(size.width, size.height)
var after = w.getSize() assertBoundsEqual(w.getSize(), [size.width, size.height])
assert.equal(after[0], size.width)
assert.equal(after[1], size.height)
}) })
}) })
@ -1375,7 +1369,7 @@ const assertBoundsEqual = (actual, expect) => {
} }
const assertWithinDelta = (actual, expect, delta, label) => { const assertWithinDelta = (actual, expect, delta, label) => {
const result = Math.abs(actual[0] - expect[0]) const result = Math.abs(actual - expect)
assert.ok(result <= delta, `${label} value of ${expect} was not within ${delta} of ${actual}`) assert.ok(result <= delta, `${label} value of ${expect} was not within ${delta} of ${actual}`)
} }