From 13749797ecbd1845230424d2e64664b4619d5255 Mon Sep 17 00:00:00 2001 From: Felix Rieseberg Date: Tue, 7 Nov 2017 21:39:59 -0800 Subject: [PATCH 1/3] :memo: Document setPermissionRequestHandler(null) --- docs/api/session.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/api/session.md b/docs/api/session.md index 25ca1b3a8242..64cb7caf4fa1 100644 --- a/docs/api/session.md +++ b/docs/api/session.md @@ -287,7 +287,7 @@ win.webContents.session.setCertificateVerifyProc((request, callback) => { #### `ses.setPermissionRequestHandler(handler)` -* `handler` Function +* `handler` Function | null * `webContents` [WebContents](web-contents.md) - WebContents requesting the permission. * `permission` String - Enum of 'media', 'geolocation', 'notifications', 'midiSysex', 'pointerLock', 'fullscreen', 'openExternal'. @@ -296,6 +296,7 @@ win.webContents.session.setCertificateVerifyProc((request, callback) => { Sets the handler which can be used to respond to permission requests for the `session`. Calling `callback(true)` will allow the permission and `callback(false)` will reject it. +To clear the handler, call `setPermissionRequestHandler(null)`. ```javascript const {session} = require('electron') From 4f6bdc5824be7abe88725c0efb5c5a22c3f90c2b Mon Sep 17 00:00:00 2001 From: Felix Rieseberg Date: Mon, 20 Nov 2017 08:24:39 -0800 Subject: [PATCH 2/3] :package: Bump electron-docs-linter --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index d42bf431af31..12da08b1b471 100644 --- a/package.json +++ b/package.json @@ -11,7 +11,7 @@ "dotenv-safe": "^4.0.4", "dugite": "^1.45.0", "electabul": "~0.0.4", - "electron-docs-linter": "^2.3.3", + "electron-docs-linter": "^2.3.4", "electron-typescript-definitions": "^1.2.10", "github": "^9.2.0", "husky": "^0.14.3", From 3c384383032c036e289ffddb68a1cada3a2d775a Mon Sep 17 00:00:00 2001 From: Felix Rieseberg Date: Mon, 20 Nov 2017 09:54:00 -0800 Subject: [PATCH 3/3] :package: Update electron-typescript-definitions --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 12da08b1b471..6438027a350b 100644 --- a/package.json +++ b/package.json @@ -12,7 +12,7 @@ "dugite": "^1.45.0", "electabul": "~0.0.4", "electron-docs-linter": "^2.3.4", - "electron-typescript-definitions": "^1.2.10", + "electron-typescript-definitions": "^1.2.11", "github": "^9.2.0", "husky": "^0.14.3", "minimist": "^1.2.0",