mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: backport Node nested microtask fix (#20303)

Browse source
This commit is contained in:
Jeremy Apthorp 2019-09-25 17:38:50 -04:00 • committed by GitHub
parent 0653e31767
commit 593f1774e9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 82 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

11
spec-main/api-session-spec.ts
View file

@ -240,17 +240,16 @@ describe('session module', () => {
const port = (downloadServer.address() as AddressInfo).port
const url = `http://127.0.0.1:${port}/`
const downloadPrevented: Promise<Electron.DownloadItem> = new Promise(resolve => {
const downloadPrevented: Promise<{itemUrl: string, itemFilename: string, item: Electron.DownloadItem}> = new Promise(resolve => {
w.webContents.session.once('will-download', function (e, item) {
e.preventDefault()
resolve(item)
resolve({itemUrl: item.getURL(), itemFilename: item.getFilename(), item})
})
})
w.loadURL(url)
const item = await downloadPrevented
expect(item.getURL()).to.equal(url)
expect(item.getFilename()).to.equal('mockFile.txt')
await new Promise(setImmediate)
const {item, itemUrl, itemFilename} = await downloadPrevented
expect(itemUrl).to.equal(url)
expect(itemFilename).to.equal('mockFile.txt')
expect(() => item.getURL()).to.throw('Object has been destroyed')
})
})