mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: re-enable mixed-sandbox tests

Browse source
This commit is contained in:
Shelley Vohr 2018-08-12 21:29:29 -07:00
parent c0959bd534
commit 590ae5cd29
No known key found for this signature in database
GPG key ID: F13993A75599653C
1 changed files with 0 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
spec/api-app-spec.js
View file

@ -869,13 +869,6 @@ describe('app module', () => {
}) })
describe('when app.enableMixedSandbox() is called', () => { describe('when app.enableMixedSandbox() is called', () => {
// TODO(zcbenz): Find out why it fails in CI.
before(function () {
if (isCI && process.platform === 'win32') {
this.skip()
}
})
it('adds --enable-sandbox to render processes created with sandbox: true', done => { it('adds --enable-sandbox to render processes created with sandbox: true', done => {
const appPath = path.join(__dirname, 'fixtures', 'api', 'mixed-sandbox-app') const appPath = path.join(__dirname, 'fixtures', 'api', 'mixed-sandbox-app')
appProcess = ChildProcess.spawn(remote.process.execPath, [appPath]) appProcess = ChildProcess.spawn(remote.process.execPath, [appPath])
@ -898,13 +891,6 @@ describe('app module', () => {
}) })
describe('when the app is launched with --enable-mixed-sandbox', () => { describe('when the app is launched with --enable-mixed-sandbox', () => {
// TODO(zcbenz): Find out why it fails in CI.
before(function () {
if (isCI && process.platform === 'win32') {
this.skip()
}
})
it('adds --enable-sandbox to render processes created with sandbox: true', done => { it('adds --enable-sandbox to render processes created with sandbox: true', done => {
const appPath = path.join(__dirname, 'fixtures', 'api', 'mixed-sandbox-app') const appPath = path.join(__dirname, 'fixtures', 'api', 'mixed-sandbox-app')
appProcess = ChildProcess.spawn(remote.process.execPath, [appPath, '--enable-mixed-sandbox']) appProcess = ChildProcess.spawn(remote.process.execPath, [appPath, '--enable-mixed-sandbox'])