From 58abc757fdd992ce6554fc9a83c7ab647fc94e39 Mon Sep 17 00:00:00 2001 From: John Kleinschmidt Date: Tue, 19 Nov 2019 06:36:16 -0800 Subject: [PATCH] build: use symbol_level 1 for 32bit linux releases (#21193) * build: use symbol_level 1 for 32bit linux releases * Add comment --- .circleci/config.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 0b168144c72..7fd2f376a43 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -151,6 +151,10 @@ env-ninja-status: &env-ninja-status env-disable-run-as-node: &env-disable-run-as-node GN_BUILDFLAG_ARGS: 'enable_run_as_node = false' +env-32bit-release: &env-32bit-release + # Set symbol level to 1 for 32 bit releases because of https://crbug.com/648948 + GN_BUILDFLAG_ARGS: 'symbol_level = 1' + # Individual (shared) steps. step-maybe-notify-slack-failure: &step-maybe-notify-slack-failure run: @@ -1428,6 +1432,7 @@ jobs: <<: *env-ia32 <<: *env-release-build <<: *env-enable-sccache + <<: *env-32bit-release UPLOAD_TO_S3: << pipeline.parameters.upload-to-s3 >> <<: *steps-electron-build-for-publish @@ -1471,6 +1476,7 @@ jobs: <<: *env-arm <<: *env-release-build <<: *env-enable-sccache + <<: *env-32bit-release GCLIENT_EXTRA_ARGS: '--custom-var=checkout_arm=True --custom-var=checkout_boto=True --custom-var=checkout_requests=True' UPLOAD_TO_S3: << pipeline.parameters.upload-to-s3 >> <<: *steps-electron-build-for-publish