mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

👷 Tests, how do they work

Browse source
This commit is contained in:
Felix Rieseberg 2018-03-13 17:35:55 -07:00
parent 1b3568e66e
commit 582ef30b4a
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/common/api/crash-reporter.js
View file

@ -66,8 +66,8 @@ class CrashReporter {
getLastCrashReport () { getLastCrashReport () {
const reports = this.getUploadedReports() const reports = this.getUploadedReports()
.sort((a, b) => { .sort((a, b) => {
const ats = (a && a.timestamp) ? new Date(a.timestamp).getTime() : 0 const ats = (a && a.date) ? new Date(a.date).getTime() : 0
const bts = (b && b.timestamp) ? new Date(b.timestamp).getTime() : 0 const bts = (b && b.date) ? new Date(b.date).getTime() : 0
return bts - ats return bts - ats
}) })

6
spec/api-crash-reporter-spec.js
View file

@ -263,15 +263,15 @@ describe('crashReporter module', () => {
// Let's find the newest report // Let's find the newest report
const newestReport = reports.reduce((acc, cur) => { const newestReport = reports.reduce((acc, cur) => {
const timestamp = new Date(cur.timestamp).getTime(); const timestamp = new Date(cur.date).getTime();
return (timestamp > acc.timestamp) return (timestamp > acc.timestamp)
? { report: cur, timestamp: timestamp } ? { report: cur, timestamp: timestamp }
: acc : acc
}, { timestamp: 0 }) }, { timestamp: 0 })
// In our case, the first report is actually the newest
assert(lastReport != null) assert(lastReport != null)
assert(lastReport === newestReport.report) assert(lastReport.date.toString() === newestReport.report.date.toString())
}) })
}) })