diff --git a/brightray/browser/inspectable_web_contents_delegate.h b/brightray/browser/inspectable_web_contents_delegate.h index 7ef79f60e0e3..0b2f3f6a2b2a 100644 --- a/brightray/browser/inspectable_web_contents_delegate.h +++ b/brightray/browser/inspectable_web_contents_delegate.h @@ -18,7 +18,8 @@ class InspectableWebContentsDelegate { // Called when the devtools is going to be showed, returning true to override // the default behavior. - virtual bool DevToolsShow(const std::string& side) { return false; } + // Receiver is given the chance to change the |dock_side|. + virtual bool DevToolsShow(std::string* dock_side) { return false; } }; } // namespace brightray diff --git a/brightray/browser/inspectable_web_contents_impl.cc b/brightray/browser/inspectable_web_contents_impl.cc index cf73a26443d0..c4a8f75ef4b5 100644 --- a/brightray/browser/inspectable_web_contents_impl.cc +++ b/brightray/browser/inspectable_web_contents_impl.cc @@ -94,7 +94,7 @@ void InspectableWebContentsImpl::ShowDevTools() { std::string()); } - if (delegate_ && delegate_->DevToolsShow(dock_side_)) + if (delegate_ && delegate_->DevToolsShow(&dock_side_)) return; view_->SetDockSide(dock_side_);