mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

build: Wrap bundles using webpack (#25557)

Browse source
This commit is contained in:
Julie Koubová 2020-10-20 21:10:15 +02:00 • committed by GitHub
parent f7945ade07
commit 56d1fafe66
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 169 additions and 178 deletions
Download patch file Download diff file Expand all files Collapse all files

2
shell/common/node_bindings.cc
View file

@ -424,7 +424,7 @@ node::Environment* NodeBindings::CreateEnvironment(
DCHECK(env);
// This will only be caught when something has gone terrible wrong as all
// electron scripts are wrapped in a try {} catch {} in run-compiler.js
// electron scripts are wrapped in a try {} catch {} by webpack
if (try_catch.HasCaught()) {
LOG(ERROR) << "Failed to initialize node environment in process: "
<< process_type;

2
shell/common/node_util.cc
View file

@ -29,7 +29,7 @@ v8::MaybeLocal<v8::Value> CompileAndCall(
v8::MaybeLocal<v8::Value> ret = fn->Call(
context, v8::Null(isolate), arguments->size(), arguments->data());
// This will only be caught when something has gone terrible wrong as all
// electron scripts are wrapped in a try {} catch {} in run-compiler.js
// electron scripts are wrapped in a try {} catch {} by webpack
if (try_catch.HasCaught()) {
LOG(ERROR) << "Failed to CompileAndCall electron script: " << id;
}