mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix floating reference glib warning (#11948)

Browse source 
use gtk_widget_destroy() rather than g_object_unref() on the floating temporary menubar widget that we use to calculate colors
This commit is contained in:
Charles Kerr 2018-02-19 00:12:54 -06:00 committed by GitHub
parent 55d4d74624
commit 56859531cd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
atom/browser/ui/views/menu_bar.cc
View file

@ -57,7 +57,7 @@ void GetMenuBarColor(SkColor* enabled,
*highlight = GetStyleContextFgColor(sc, GTK_STATE_FLAG_SELECTED); *highlight = GetStyleContextFgColor(sc, GTK_STATE_FLAG_SELECTED);
*hover = GetStyleContextFgColor(sc, GTK_STATE_FLAG_PRELIGHT); *hover = GetStyleContextFgColor(sc, GTK_STATE_FLAG_PRELIGHT);
*background = GetStyleContextBgColor(sc, GTK_STATE_FLAG_NORMAL); *background = GetStyleContextBgColor(sc, GTK_STATE_FLAG_NORMAL);
g_object_unref(G_OBJECT(menu_bar)); gtk_widget_destroy(GTK_WIDGET(menu_bar));
} }
#endif // USE_X11 #endif // USE_X11