mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: prefer empty() check for readability (#26109)

Browse source
This commit is contained in:
David Sanders 2020-10-22 13:24:59 -07:00 • committed by GitHub
parent d9db9873fd
commit 554ad93d45
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 15 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

2
shell/browser/api/electron_api_base_window.cc
View file

@ -951,7 +951,7 @@ std::vector<v8::Local<v8::Object>> BaseWindow::GetChildWindows() const {
v8::Local<v8::Value> BaseWindow::GetBrowserView(
gin_helper::Arguments* args) const {
if (browser_views_.size() == 0) {
if (browser_views_.empty()) {
return v8::Null(isolate());
} else if (browser_views_.size() == 1) {
auto first_view = browser_views_.begin();

4
shell/browser/api/electron_api_web_contents.cc
View file

@ -406,7 +406,7 @@ base::string16 GetDefaultPrinterAsync() {
if (printer_name.empty()) {
printing::PrinterList printers;
print_backend->EnumeratePrinters(&printers);
if (printers.size() > 0)
if (!printers.empty())
printer_name = printers.front().printer_name;
}
return base::UTF8ToUTF16(printer_name);
@ -2187,7 +2187,7 @@ void WebContents::Print(gin::Arguments* args) {
continue;
}
}
if (page_range_list.GetList().size() > 0)
if (!page_range_list.GetList().empty())
settings.SetPath(printing::kSettingPageRange, std::move(page_range_list));
}