mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feat: just enough //extensions to load a simple devtools extension (#19515)

Browse source
This commit is contained in:
Jeremy Apthorp 2020-01-14 16:20:30 -08:00 • committed by GitHub
parent 9c1310dadc
commit 55368e4d97
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
14 changed files with 250 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

6
shell/common/extensions/api/_manifest_features.json
View file

@ -9,6 +9,10 @@
{
"content_scripts": {
"channel": "stable",
"extension_types": ["extension", "legacy_packaged_app"]
"extension_types": ["extension"]
},
"devtools_page": {
"channel": "stable",
"extension_types": ["extension"]
}
}

73
shell/common/extensions/atom_extensions_api_provider.cc
View file

@ -4,14 +4,69 @@
#include "shell/common/extensions/atom_extensions_api_provider.h"
#include <memory>
#include <string>
#include <utility>
#include "base/containers/span.h"
#include "base/strings/utf_string_conversions.h"
#include "electron/buildflags/buildflags.h"
#include "extensions/common/alias.h"
#include "extensions/common/features/json_feature_provider_source.h"
#if BUILDFLAG(ENABLE_ELECTRON_EXTENSIONS)
#include "extensions/common/manifest_constants.h"
#include "extensions/common/manifest_handler.h"
#include "extensions/common/manifest_handlers/permissions_parser.h"
#include "extensions/common/manifest_url_handlers.h"
#include "extensions/common/permissions/permissions_info.h"
#include "shell/common/extensions/api/manifest_features.h"
#endif
namespace extensions {
namespace keys = manifest_keys;
namespace errors = manifest_errors;
// Parses the "devtools_page" manifest key.
class DevToolsPageHandler : public ManifestHandler {
public:
DevToolsPageHandler() = default;
~DevToolsPageHandler() override = default;
bool Parse(Extension* extension, base::string16* error) override {
std::unique_ptr<ManifestURL> manifest_url(new ManifestURL);
std::string devtools_str;
if (!extension->manifest()->GetString(keys::kDevToolsPage, &devtools_str)) {
*error = base::ASCIIToUTF16(errors::kInvalidDevToolsPage);
return false;
}
manifest_url->url_ = extension->GetResourceURL(devtools_str);
extension->SetManifestData(keys::kDevToolsPage, std::move(manifest_url));
PermissionsParser::AddAPIPermission(extension, APIPermission::kDevtools);
return true;
}
private:
base::span<const char* const> Keys() const override {
static constexpr const char* kKeys[] = {keys::kDevToolsPage};
return kKeys;
}
DISALLOW_COPY_AND_ASSIGN(DevToolsPageHandler);
};
constexpr APIPermissionInfo::InitInfo permissions_to_register[] = {
{APIPermission::kDevtools, "devtools",
APIPermissionInfo::kFlagImpliesFullURLAccess |
APIPermissionInfo::kFlagCannotBeOptional |
APIPermissionInfo::kFlagInternal},
};
base::span<const APIPermissionInfo::InitInfo> GetPermissionInfos() {
return base::make_span(permissions_to_register);
}
base::span<const Alias> GetPermissionAliases() {
return base::span<const Alias>();
}
} // namespace extensions
namespace electron {
@ -60,8 +115,16 @@ base::StringPiece AtomExtensionsAPIProvider::GetAPISchema(
}
void AtomExtensionsAPIProvider::RegisterPermissions(
extensions::PermissionsInfo* permissions_info) {}
extensions::PermissionsInfo* permissions_info) {
permissions_info->RegisterPermissions(extensions::GetPermissionInfos(),
extensions::GetPermissionAliases());
}
void AtomExtensionsAPIProvider::RegisterManifestHandlers() {}
void AtomExtensionsAPIProvider::RegisterManifestHandlers() {
extensions::ManifestHandlerRegistry* registry =
extensions::ManifestHandlerRegistry::Get();
registry->RegisterHandler(
std::make_unique<extensions::DevToolsPageHandler>());
}
} // namespace electron