mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: improve cookie failure rejection messages (#42362)

Browse source
This commit is contained in:
Shelley Vohr 2024-06-07 10:06:37 +02:00 • committed by GitHub
parent 7f3dc7d4ce
commit 54c315c9b0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 105 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

18
spec/api-session-spec.ts
View file

@ -126,24 +126,34 @@ describe('session module', () => {
expect(cs.some(c => c.name === name && c.value === value)).to.equal(true);
});
it('yields an error when setting a cookie with missing required fields', async () => {
it('rejects when setting a cookie with missing required fields', async () => {
const { cookies } = session.defaultSession;
const name = '1';
const value = '1';
await expect(
cookies.set({ url: '', name, value })
).to.eventually.be.rejectedWith('Failed to set cookie with an invalid domain attribute');
).to.eventually.be.rejectedWith('Failed to set cookie - The cookie was set with an invalid Domain attribute.');
});
it('yields an error when setting a cookie with an invalid URL', async () => {
it('rejects when setting a cookie with an invalid URL', async () => {
const { cookies } = session.defaultSession;
const name = '1';
const value = '1';
await expect(
cookies.set({ url: 'asdf', name, value })
).to.eventually.be.rejectedWith('Failed to set cookie with an invalid domain attribute');
).to.eventually.be.rejectedWith('Failed to set cookie - The cookie was set with an invalid Domain attribute.');
});
it('rejects when setting a cookie with an invalid ASCII control character', async () => {
const { cookies } = session.defaultSession;
const name = 'BadCookie';
const value = 'test;test';
await expect(
cookies.set({ url, name, value })
).to.eventually.be.rejectedWith('Failed to set cookie - The cookie contains ASCII control characters');
});
it('should overwrite previous cookies', async () => {