mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Free the native window's memory after the event were sent for all observers.

Browse source 
If we delete the window immediately other observers may get a invalid
window and cause random crashes.
This commit is contained in:
Cheng Zhao 2013-09-27 15:20:55 +08:00
parent 10a46b4229
commit 54b0d0c9c0
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
browser/api/atom_api_window.cc
View file

@ -61,8 +61,9 @@ void Window::WillCloseWindow(bool* prevent_default) {
void Window::OnWindowClosed() { void Window::OnWindowClosed() {
Emit("closed"); Emit("closed");
// Free memory immediately when window is closed. // Free memory when native window is closed, the delete is delayed so other
delete this; // observers would not get a invalid pointer of NativeWindow.
base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);
} }
void Window::OnWindowBlur() { void Window::OnWindowBlur() {