mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Ignore native module tests on Windows debug build

Browse source 
This resolves #2558. There are no more errors when running test.py on
the debug build in Windows. When running the release build the tests
will be executed as usual.
This commit is contained in:
Eran Tiktin 2015-08-27 23:05:06 +03:00
parent b7d80e792d
commit 5337d8c23f
4 changed files with 40 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.gitignore vendored
View file

@ -17,3 +17,4 @@ node_modules/
*.pyc *.pyc
debug.log debug.log
npm-debug.log npm-debug.log
atom/common/chrome_version.h

9
docs/development/build-instructions-windows.md
View file

@ -82,6 +82,15 @@ Test functionality using:
python script\test.py python script\test.py
``` ```
Tests that include native modules (e.g. `runas`) can't be executed with the
debug build (see #2558 for details), but they will work with the release build.
To run the tests with the release build use:
```powershell
python script\test.py -R
```
## Troubleshooting ## Troubleshooting
### Command xxxx not found ### Command xxxx not found

4
spec/modules-spec.coffee
View file

@ -7,6 +7,10 @@ describe 'third-party module', ->
fixtures = path.join __dirname, 'fixtures' fixtures = path.join __dirname, 'fixtures'
temp.track() temp.track()
# If the test is executed with the debug build on Windows, we will skip it
# because native modules don't work with the debug build (see issue #2558).
if process.platform isnt 'win32' or
process.execPath.toLowerCase().indexOf('\\out\\d\\') is -1
describe 'runas', -> describe 'runas', ->
it 'can be required in renderer', -> it 'can be required in renderer', ->
require 'runas' require 'runas'

4
spec/webview-spec.coffee
View file

@ -48,6 +48,10 @@ describe '<webview> tag', ->
webview.src = "file://#{fixtures}/pages/d.html" webview.src = "file://#{fixtures}/pages/d.html"
document.body.appendChild webview document.body.appendChild webview
# If the test is executed with the debug build on Windows, we will skip it
# because native modules don't work with the debug build (see issue #2558).
if process.platform isnt 'win32' or
process.execPath.toLowerCase().indexOf('\\out\\d\\') is -1
it 'loads native modules when navigation happens', (done) -> it 'loads native modules when navigation happens', (done) ->
listener = (e) -> listener = (e) ->
webview.removeEventListener 'did-finish-load', listener webview.removeEventListener 'did-finish-load', listener