mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Pass arguments instance through the chain in order to throw error

Browse source
This commit is contained in:
Samuel Attard 2018-02-27 16:11:54 +11:00
parent e84d7c0cda
commit 5336b4a89c
6 changed files with 14 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

9
atom/browser/api/atom_api_browser_window.cc
View file

@ -1082,8 +1082,13 @@ void BrowserWindow::ToggleTabBar() {
window_->ToggleTabBar();
}
void BrowserWindow::AddTabbedWindow(NativeWindow* window) {
window_->AddTabbedWindow(window);
void BrowserWindow::AddTabbedWindow(mate::Arguments* args) {
NativeWindow* window;
if (!args->GetNext(&window)) {
args->ThrowError("Insert good error message here");
return;
}
window_->AddTabbedWindow(window, args);
}
void BrowserWindow::SetVibrancy(mate::Arguments* args) {

2
atom/browser/api/atom_api_browser_window.h
View file

@ -243,7 +243,7 @@ class BrowserWindow : public mate::TrackableObject<BrowserWindow>,
void MergeAllWindows();
void MoveTabToNewWindow();
void ToggleTabBar();
void AddTabbedWindow(NativeWindow* window);
void AddTabbedWindow(mate::Arguments* args);
void SetVibrancy(mate::Arguments* args);
void SetTouchBar(const std::vector<mate::PersistentDictionary>& items);