mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: beep on Ubuntu (#16350)

Browse source 
beeps on Linux are made by writing BEL to /dev/console,
which requires elevated permissions on Ubuntu. So if
opening /dev/console fails, fall back to /dev/tty.
This commit is contained in:
Charles Kerr 2019-01-10 15:43:07 -06:00 • committed by Shelley Vohr
parent d0ae89befa
commit 52852b963a
1 changed files with 8 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

13
atom/common/platform_util_linux.cc
View file

@ -140,11 +140,14 @@ bool MoveItemToTrash(const base::FilePath& full_path) {
void Beep() { void Beep() {
// echo '\a' > /dev/console // echo '\a' > /dev/console
FILE* console = fopen("/dev/console", "r"); FILE* fp = fopen("/dev/console", "a");
if (console == NULL) if (fp == nullptr) {
return; fp = fopen("/dev/tty", "a");
fprintf(console, "\a"); }
fclose(console); if (fp != nullptr) {
fprintf(fp, "\a");
fclose(fp);
}
} }
bool GetDesktopName(std::string* setme) { bool GetDesktopName(std::string* setme) {