mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: use Map for callbacks in CallbacksRegistry (#20565)

Browse source
This commit is contained in:
Milan Burda 2019-10-15 18:14:41 +02:00 committed by Shelley Vohr
parent dceabf231b
commit 5273930f76
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/renderer/remote/callbacks-registry.ts
View file

@ -2,7 +2,7 @@ const v8Util = process.electronBinding('v8_util')
export class CallbacksRegistry {
private nextId: number = 0
private callbacks: Record<number, Function> = {}
private callbacks = new Map<number, Function>()
add (callback: Function) {
// The callback is already added.
@ -31,14 +31,14 @@ export class CallbacksRegistry {
break
}
this.callbacks[id] = callback
this.callbacks.set(id, callback)
v8Util.setHiddenValue(callback, 'callbackId', id)
v8Util.setHiddenValue(callback, 'location', filenameAndLine)
return id
}
get (id: number) {
return this.callbacks[id] || function () {}
return this.callbacks.get(id) || function () {}
}
apply (id: number, ...args: any[]) {
@ -46,10 +46,10 @@ export class CallbacksRegistry {
}
remove (id: number) {
const callback = this.callbacks[id]
const callback = this.callbacks.get(id)
if (callback) {
v8Util.deleteHiddenValue(callback, 'callbackId')
delete this.callbacks[id]
this.callbacks.delete(id)
}
}
}