Only document deprecation for now

This commit is contained in:
Kevin Sawicki 2017-02-07 15:44:56 -08:00
parent 9c134e7bf3
commit 5245d42d15
2 changed files with 16 additions and 9 deletions

View file

@ -1,5 +1,5 @@
const {EventEmitter} = require('events')
const {app, deprecate} = require('electron')
const {app} = require('electron')
const {fromPartition, Session, Cookies} = process.atomBinding('session')
// Public API.
@ -21,15 +21,9 @@ Session.prototype._init = function () {
app.emit('session-created', this)
}
// Remove after 2.0
Session.prototype.setCertificateVerifyProc = function (verifyProc) {
if (!verifyProc) {
this._setCertificateVerifyProc(null)
return
}
if (verifyProc.length <= 3) {
deprecate.warn('setCertificateVerifyproc(hostname, certificate, callback)',
'setCertificateVerifyproc(hostname, certificate, error, callback)')
if (verifyProc != null && verifyProc.length <= 3) {
// TODO(kevinsawicki): Remove in 2.0, deprecate before then with warnings
this._setCertificateVerifyProc((hostname, certificate, error, cb) => {
verifyProc(hostname, certificate, (result) => {
cb(result ? 0 : -2)