From 522ae765ea460a86660b82e22caab7561b6bbda7 Mon Sep 17 00:00:00 2001 From: Brent Ertz Date: Wed, 5 Nov 2014 11:21:18 -0700 Subject: [PATCH] Updates per PR feedback * Use backticks instead of quotes around code object * Remove path.join usage * Dasherize event names --- docs/tutorial/online-offline-events.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/tutorial/online-offline-events.md b/docs/tutorial/online-offline-events.md index 825296dd4133..eab6ce8a0be1 100644 --- a/docs/tutorial/online-offline-events.md +++ b/docs/tutorial/online-offline-events.md @@ -12,7 +12,7 @@ var onlineStatusWindow; app.on('ready', function() { onlineStatusWindow = new BrowserWindow({ width: 0, height: 0, show: false }); - onlineStatusWindow.loadUrl('file://' + path.join(__dirname, '/online-status.html')); + onlineStatusWindow.loadUrl('file://' + __dirname + '/online-status.html'); }); ``` @@ -37,7 +37,7 @@ _online-status.html_ There may be instances where one wants to respond to these events in the browser process as well. The browser process however does not have a -"navigator" object and thus cannot detect these events directly. Using +`navigator` object and thus cannot detect these events directly. Using Atom-shell's inter-process communication utilities, the events can be forwarded to the browser process and handled as needed, as shown in the following example. @@ -51,10 +51,10 @@ var onlineStatusWindow; app.on('ready', function() { onlineStatusWindow = new BrowserWindow({ width: 0, height: 0, show: false }); - onlineStatusWindow.loadUrl('file://' + path.join(__dirname, '/online-status.html')); + onlineStatusWindow.loadUrl('file://' + __dirname + '/online-status.html'); }); -ipc.on('onlineStatusMessage', function(event, status) { +ipc.on('online-status-changed', function(event, status) { console.log(status); }); ``` @@ -67,7 +67,7 @@ _online-status.html_