mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Make sure symbol is dumped from unstripped binary.

Browse source
This commit is contained in:
Cheng Zhao 2014-03-03 14:14:02 +08:00
parent b8e75df8f0
commit 51f0090555
1 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

14
script/create-dist.py
View file

@ -9,7 +9,7 @@ import tarfile
from lib.config import LIBCHROMIUMCONTENT_COMMIT, BASE_URL, NODE_VERSION from lib.config import LIBCHROMIUMCONTENT_COMMIT, BASE_URL, NODE_VERSION
from lib.util import scoped_cwd, rm_rf, get_atom_shell_version, make_zip, \ from lib.util import scoped_cwd, rm_rf, get_atom_shell_version, make_zip, \
safe_mkdir, execute safe_mkdir, safe_unlink, execute
ATOM_SHELL_VRESION = get_atom_shell_version() ATOM_SHELL_VRESION = get_atom_shell_version()
@ -81,6 +81,8 @@ def main():
args = parse_args() args = parse_args()
if TARGET_PLATFORM == 'linux':
clean_build()
force_build() force_build()
if TARGET_PLATFORM != 'linux': if TARGET_PLATFORM != 'linux':
download_libchromiumcontent_symbols(args.url) download_libchromiumcontent_symbols(args.url)
@ -105,6 +107,16 @@ def parse_args():
return parser.parse_args() return parser.parse_args()
def clean_build():
# On Linux stripping binary would cause them to be rebuilt next time, which
# would make create-dist create symbols from stripped binary if it has been
# ran for twice.
# So in order to make sure we built correct symbols everytime, we have to
# force a rebuild of the binaries.
for binary in TARGET_BINARIES[TARGET_PLATFORM]:
safe_unlink(os.path.join(OUT_DIR, binary))
def force_build(): def force_build():
build = os.path.join(SOURCE_ROOT, 'script', 'build.py') build = os.path.join(SOURCE_ROOT, 'script', 'build.py')
execute([sys.executable, build, '-c', 'Release']) execute([sys.executable, build, '-c', 'Release'])