mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Don't make use of the 'id' property when sending objects.

Browse source 
Fixes #43.
This commit is contained in:
Cheng Zhao 2013-07-26 16:39:22 +08:00
parent 511b2a4422
commit 51a632d7d9
3 changed files with 13 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

8
renderer/api/lib/remote.coffee
View file

@ -8,8 +8,8 @@ callbacksRegistry = new CallbacksRegistry
# Convert the arguments object into an array of meta data.
wrapArgs = (args) ->
Array::slice.call(args).map (value) ->
if value? and typeof value is 'object' and v8Util.getHiddenValue value, 'isRemoteObject'
type: 'object', id: value.id
if value? and typeof value is 'object' and v8Util.getHiddenValue value, 'atomId'
type: 'object', id: v8Util.getHiddenValue value, 'atomId'
else if typeof value is 'function'
type: 'function', id: callbacksRegistry.add(value)
else
@ -68,8 +68,8 @@ metaToValue = (meta) ->
return unless currentContextExist
ipc.sendChannel 'ATOM_BROWSER_DEREFERENCE', meta.storeId
# Mark this is a remote object.
v8Util.setHiddenValue ret, 'isRemoteObject', true
# Remember object's id.
v8Util.setHiddenValue ret, 'atomId', meta.id
ret