From 51961fccfa58ae84c33dbfb54146ffc0ef08e35c Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Mon, 21 Jan 2019 15:22:56 -0800 Subject: [PATCH] build: temporarily disable arm to unblock nightlies (#16479) --- script/ci-release-build.js | 22 +++++++++++++--------- script/release.js | 14 ++++++++------ 2 files changed, 21 insertions(+), 15 deletions(-) diff --git a/script/ci-release-build.js b/script/ci-release-build.js index e2cee5fb63c6..5ad2d09c14e1 100644 --- a/script/ci-release-build.js +++ b/script/ci-release-build.js @@ -11,8 +11,9 @@ const appVeyorJobs = { } const circleCIJobs = [ - 'linux-arm-publish', - 'linux-arm64-publish', + // FIXME(codebytere): re-enable + // 'linux-arm-publish', + // 'linux-arm64-publish', 'linux-ia32-publish', 'linux-x64-publish' ] @@ -22,10 +23,11 @@ const vstsJobs = [ 'electron-release-osx-x64' ] -const vstsArmJobs = [ - 'electron-arm-testing', - 'electron-arm64-testing' -] +// FIXME(codebytere): re-enable +// const vstsArmJobs = [ +// 'electron-arm-testing', +// 'electron-arm64-testing' +// ] async function makeRequest (requestOptions, parseResponse) { return new Promise((resolve, reject) => { @@ -134,9 +136,11 @@ function buildCircleCI (targetBranch, options) { } async function buildVSTS (targetBranch, options) { - if (options.armTest) { - assert(vstsArmJobs.includes(options.job), `Unknown VSTS CI arm test job name: ${options.job}. Valid values are: ${vstsArmJobs}.`) - } else if (options.job) { + // FIXME(codebytere): re-enable + // if (options.armTest) { + // assert(vstsArmJobs.includes(options.job), `Unknown VSTS CI arm test job name: ${options.job}. Valid values are: ${vstsArmJobs}.`) + // } + if (options.job) { assert(vstsJobs.includes(options.job), `Unknown VSTS CI job name: ${options.job}. Valid values are: ${vstsJobs}.`) } console.log(`Triggering VSTS to run build on branch: ${targetBranch} with release flag.`) diff --git a/script/release.js b/script/release.js index 2e7be685ad04..168660bb96f4 100755 --- a/script/release.js +++ b/script/release.js @@ -96,10 +96,11 @@ function assetsForVersion (version, validatingRelease) { `electron-${version}-darwin-x64-dsym.zip`, `electron-${version}-darwin-x64-symbols.zip`, `electron-${version}-darwin-x64.zip`, - `electron-${version}-linux-arm64-symbols.zip`, - `electron-${version}-linux-arm64.zip`, - `electron-${version}-linux-armv7l-symbols.zip`, - `electron-${version}-linux-armv7l.zip`, + // FIXME(codebytere): re-enable + // `electron-${version}-linux-arm64-symbols.zip`, + // `electron-${version}-linux-arm64.zip`, + // `electron-${version}-linux-armv7l-symbols.zip`, + // `electron-${version}-linux-armv7l.zip`, `electron-${version}-linux-ia32-symbols.zip`, `electron-${version}-linux-ia32.zip`, `electron-${version}-linux-x64-symbols.zip`, @@ -116,8 +117,9 @@ function assetsForVersion (version, validatingRelease) { `electron-api.json`, `electron.d.ts`, `ffmpeg-${version}-darwin-x64.zip`, - `ffmpeg-${version}-linux-arm64.zip`, - `ffmpeg-${version}-linux-armv7l.zip`, + // FIXME(codebytere): re-enable + // `ffmpeg-${version}-linux-arm64.zip`, + // `ffmpeg-${version}-linux-armv7l.zip`, `ffmpeg-${version}-linux-ia32.zip`, `ffmpeg-${version}-linux-x64.zip`, `ffmpeg-${version}-mas-x64.zip`,