diff --git a/lib/browser/guest-view-manager.js b/lib/browser/guest-view-manager.js index d5f6b1d8e4b6..3b20b2800c60 100644 --- a/lib/browser/guest-view-manager.js +++ b/lib/browser/guest-view-manager.js @@ -420,10 +420,4 @@ const getGuest = function (guestInstanceId) { if (guestInstance != null) return guestInstance.guest; }; -// Returns the embedder of the guest. -const getEmbedder = function (guestInstanceId) { - const guestInstance = guestInstances[guestInstanceId]; - if (guestInstance != null) return guestInstance.embedder; -}; - exports.isWebViewTagEnabled = isWebViewTagEnabled; diff --git a/script/doc-only-change.js b/script/doc-only-change.js index 07369e932d61..39906deb7ceb 100644 --- a/script/doc-only-change.js +++ b/script/doc-only-change.js @@ -1,7 +1,6 @@ const args = require('minimist')(process.argv.slice(2)); const { Octokit } = require('@octokit/rest'); const octokit = new Octokit(); -const path = require('path'); async function checkIfDocOnlyChange () { if (args.prNumber || args.prBranch || args.prURL) { diff --git a/script/release/notes/notes.js b/script/release/notes/notes.js index 96f477cc7a8c..12aa6bdac823 100644 --- a/script/release/notes/notes.js +++ b/script/release/notes/notes.js @@ -182,7 +182,7 @@ const parseCommitMessage = (commitMessage, commit) => { } // https://help.github.com/articles/closing-issues-using-keywords/ - if ((match = body.match(/\b(?:close|closes|closed|fix|fixes|fixed|resolve|resolves|resolved|for)\s#(\d+)\b/i))) { + if (body.match(/\b(?:close|closes|closed|fix|fixes|fixed|resolve|resolves|resolved|for)\s#(\d+)\b/i)) { commit.semanticType = commit.semanticType || 'fix'; } diff --git a/script/release/prepare-release.js b/script/release/prepare-release.js index 2db7fb6fff50..3f3065dd241e 100755 --- a/script/release/prepare-release.js +++ b/script/release/prepare-release.js @@ -199,7 +199,7 @@ async function prepareRelease (isBeta, notesOnly) { const releaseNotes = await getReleaseNotes(currentBranch, newVersion); console.log(`Draft release notes are: \n${releaseNotes.text}`); } else { - const changes = await changesToRelease(currentBranch); + const changes = await changesToRelease(); if (changes) { await verifyNewVersion(); await createRelease(currentBranch, isBeta); diff --git a/spec-main/fixtures/api/sandbox.html b/spec-main/fixtures/api/sandbox.html index c0ae7c279fb0..3620f5f569ec 100644 --- a/spec-main/fixtures/api/sandbox.html +++ b/spec-main/fixtures/api/sandbox.html @@ -55,7 +55,7 @@ }, 'window-open': () => { addEventListener('load', () => { - popup = open(window.location.href, 'popup!', 'top=60,left=50,width=500,height=600') + const popup = open(window.location.href, 'popup!', 'top=60,left=50,width=500,height=600') popup.addEventListener('DOMContentLoaded', () => { popup.document.write('

scripting from opener

') popup.callback() @@ -82,7 +82,7 @@ }, 'verify-ipc-sender': () => { const {ipcRenderer} = require('electron') - popup = open() + const popup = open() ipcRenderer.once('verified', () => { ipcRenderer.send('parent-answer') }) diff --git a/spec-main/video-helpers.js b/spec-main/video-helpers.js index b64369d90640..d5538c8eab15 100644 --- a/spec-main/video-helpers.js +++ b/spec-main/video-helpers.js @@ -30,7 +30,7 @@ function atob (str) { // in this case, frames has a very specific meaning, which will be // detailed once i finish writing the code -function ToWebM (frames, outputAsArray) { +function ToWebM (frames) { const info = checkFrames(frames); // max duration by cluster in milliseconds @@ -235,7 +235,7 @@ function ToWebM (frames, outputAsArray) { if (i >= 3) { cues.data[i - 3].data[1].data[1].data = position; } - const data = generateEBML([segment.data[i]], outputAsArray); + const data = generateEBML([segment.data[i]]); position += data.size || data.byteLength || data.length; if (i !== 2) { // not cues // Save results to avoid having to encode everything twice @@ -243,7 +243,7 @@ function ToWebM (frames, outputAsArray) { } } - return generateEBML(EBML, outputAsArray); + return generateEBML(EBML); } // sums the lengths of all the frames and gets the duration, woo diff --git a/spec/static/main.js b/spec/static/main.js index ff9469ae18e6..fbe81531870c 100644 --- a/spec/static/main.js +++ b/spec/static/main.js @@ -2,7 +2,7 @@ process.throwDeprecation = false; const electron = require('electron'); -const { app, BrowserWindow, dialog, ipcMain, protocol, webContents, session } = electron; +const { app, BrowserWindow, dialog, ipcMain, session } = electron; try { require('fs').rmdirSync(app.getPath('userData'), { recursive: true });