diff --git a/lib/browser/guest-view-manager.js b/lib/browser/guest-view-manager.js index d5f6b1d8e4b6..3b20b2800c60 100644 --- a/lib/browser/guest-view-manager.js +++ b/lib/browser/guest-view-manager.js @@ -420,10 +420,4 @@ const getGuest = function (guestInstanceId) { if (guestInstance != null) return guestInstance.guest; }; -// Returns the embedder of the guest. -const getEmbedder = function (guestInstanceId) { - const guestInstance = guestInstances[guestInstanceId]; - if (guestInstance != null) return guestInstance.embedder; -}; - exports.isWebViewTagEnabled = isWebViewTagEnabled; diff --git a/script/doc-only-change.js b/script/doc-only-change.js index 07369e932d61..39906deb7ceb 100644 --- a/script/doc-only-change.js +++ b/script/doc-only-change.js @@ -1,7 +1,6 @@ const args = require('minimist')(process.argv.slice(2)); const { Octokit } = require('@octokit/rest'); const octokit = new Octokit(); -const path = require('path'); async function checkIfDocOnlyChange () { if (args.prNumber || args.prBranch || args.prURL) { diff --git a/script/release/notes/notes.js b/script/release/notes/notes.js index 96f477cc7a8c..12aa6bdac823 100644 --- a/script/release/notes/notes.js +++ b/script/release/notes/notes.js @@ -182,7 +182,7 @@ const parseCommitMessage = (commitMessage, commit) => { } // https://help.github.com/articles/closing-issues-using-keywords/ - if ((match = body.match(/\b(?:close|closes|closed|fix|fixes|fixed|resolve|resolves|resolved|for)\s#(\d+)\b/i))) { + if (body.match(/\b(?:close|closes|closed|fix|fixes|fixed|resolve|resolves|resolved|for)\s#(\d+)\b/i)) { commit.semanticType = commit.semanticType || 'fix'; } diff --git a/script/release/prepare-release.js b/script/release/prepare-release.js index 2db7fb6fff50..3f3065dd241e 100755 --- a/script/release/prepare-release.js +++ b/script/release/prepare-release.js @@ -199,7 +199,7 @@ async function prepareRelease (isBeta, notesOnly) { const releaseNotes = await getReleaseNotes(currentBranch, newVersion); console.log(`Draft release notes are: \n${releaseNotes.text}`); } else { - const changes = await changesToRelease(currentBranch); + const changes = await changesToRelease(); if (changes) { await verifyNewVersion(); await createRelease(currentBranch, isBeta); diff --git a/spec-main/fixtures/api/sandbox.html b/spec-main/fixtures/api/sandbox.html index c0ae7c279fb0..3620f5f569ec 100644 --- a/spec-main/fixtures/api/sandbox.html +++ b/spec-main/fixtures/api/sandbox.html @@ -55,7 +55,7 @@ }, 'window-open': () => { addEventListener('load', () => { - popup = open(window.location.href, 'popup!', 'top=60,left=50,width=500,height=600') + const popup = open(window.location.href, 'popup!', 'top=60,left=50,width=500,height=600') popup.addEventListener('DOMContentLoaded', () => { popup.document.write('