mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

damaged -> dirty rename, fixed misc issues, changed signature, updated docs and added tests

Browse source
This commit is contained in:
Heilig Benedek 2016-06-25 18:23:40 +02:00
parent 3c92825e2a
commit 5118def724
6 changed files with 65 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

12
atom/browser/api/atom_api_web_contents.cc
View file

@ -1197,16 +1197,18 @@ void WebContents::SendInputEvent(v8::Isolate* isolate,
void WebContents::BeginFrameSubscription(
mate::Arguments* args) {
FrameSubscriber::FrameCaptureCallback callback;
if (!args->GetNext(&callback))
return;
bool only_dirty = false;
bool only_damaged = false;
args->GetNext(&only_damaged);
if (!args->GetNext(&callback)) {
args->GetNext(&only_dirty);
if (!args->GetNext(&callback))
args->ThrowTypeError("'callback' must be defined");
}
const auto view = web_contents()->GetRenderWidgetHostView();
if (view) {
std::unique_ptr<FrameSubscriber> frame_subscriber(new FrameSubscriber(
isolate(), view, callback, only_damaged));
isolate(), view, callback, only_dirty));
view->BeginFrameSubscription(std::move(frame_subscriber));
}
}