mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: -Wunsafe-buffer-usage warning in asar_util's ReadFileToString() (#43896)

Browse source
This commit is contained in:
Charles Kerr 2024-09-24 15:41:24 -05:00 • committed by GitHub
parent e64a66bfd3
commit 500d4f0d05
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
shell/common/asar/asar_util.cc
View file

@ -126,11 +126,8 @@ bool ReadFileToString(const base::FilePath& path, std::string* contents) {
return false; return false;
contents->resize(info.size); contents->resize(info.size);
if (static_cast<int>(info.size) != if (!src.ReadAndCheck(info.offset, base::as_writable_byte_span(*contents)))
src.Read(info.offset, const_cast<char*>(contents->data()),
contents->size())) {
return false; return false;
}
if (info.integrity) if (info.integrity)
ValidateIntegrityOrDie(base::as_byte_span(*contents), *info.integrity); ValidateIntegrityOrDie(base::as_byte_span(*contents), *info.integrity);