mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Remove "async" option from menu.popup()

Browse source 
All menus are async now. See "Cleanup MenuRunner API"
https://codereview.chromium.org/2790773002
This commit is contained in:
Birunthan Mohanathas 2017-09-14 00:13:45 +03:00 • committed by Cheng Zhao
parent 338604239d
commit 4e859b4718
7 changed files with 32 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

5
atom/browser/api/atom_api_menu_views.cc
View file

@ -20,8 +20,7 @@ MenuViews::MenuViews(v8::Isolate* isolate, v8::Local<v8::Object> wrapper)
weak_factory_(this) {
}
void MenuViews::PopupAt(
Window* window, int x, int y, int positioning_item, bool async) {
void MenuViews::PopupAt(Window* window, int x, int y, int positioning_item) {
NativeWindow* native_window = static_cast<NativeWindow*>(window->window());
if (!native_window)
return;
@ -42,8 +41,6 @@ void MenuViews::PopupAt(
}
int flags = MenuRunner::CONTEXT_MENU | MenuRunner::HAS_MNEMONICS;
if (async)
flags |= MenuRunner::ASYNC;
// Don't emit unresponsive event when showing menu.
atom::UnresponsiveSuppressor suppressor;