mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: don't call ReadRawDataComplete if it's not necessary (#15185)

Browse source
This commit is contained in:
Heilig Benedek 2018-10-17 06:57:26 +02:00 • committed by Shelley Vohr
parent d43ef97a7b
commit 4d085c4aae
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
atom/browser/net/url_request_stream_job.cc
View file

@ -153,14 +153,18 @@ void URLRequestStreamJob::OnData(std::vector<char>&& buffer) { // NOLINT
if (pending_buf_) { if (pending_buf_) {
int len = BufferCopy(&write_buffer_, pending_buf_.get(), pending_buf_size_); int len = BufferCopy(&write_buffer_, pending_buf_.get(), pending_buf_size_);
write_buffer_.erase(write_buffer_.begin(), write_buffer_.begin() + len); write_buffer_.erase(write_buffer_.begin(), write_buffer_.begin() + len);
pending_buf_ = nullptr;
pending_buf_size_ = 0;
ReadRawDataComplete(len); ReadRawDataComplete(len);
} }
} }
void URLRequestStreamJob::OnEnd() { void URLRequestStreamJob::OnEnd() {
ended_ = true; ended_ = true;
if (pending_buf_) {
ReadRawDataComplete(0); ReadRawDataComplete(0);
} }
}
void URLRequestStreamJob::OnError(int error) { void URLRequestStreamJob::OnError(int error) {
NotifyStartError(net::URLRequestStatus(net::URLRequestStatus::FAILED, error)); NotifyStartError(net::URLRequestStatus(net::URLRequestStatus::FAILED, error));